Always include default deny list in deny list values#5708
Merged
christopherholland-workday merged 4 commits intomainfrom Feb 24, 2026
Merged
Always include default deny list in deny list values#5708christopherholland-workday merged 4 commits intomainfrom
christopherholland-workday merged 4 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly modifies the getHttpDenyList function to ensure that the default deny list is always included, even when a custom deny list is provided via the HTTP_DENY_LIST environment variable. This is a good security enhancement. I've added one suggestion to make the implementation more robust by handling potential duplicate entries and empty strings in the custom list.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
igor-magun-wd
approved these changes
Feb 4, 2026
christopherholland-workday
requested review from
0xi4o,
HenryHengZJ and
yau-wd
HenryHengZJ
approved these changes
Feb 24, 2026
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #5702
If there is a specified deny list, we should not throw out any protection of local hosts. Instead, we should add the default deny-list to the provided deny-list.