Skip to content

Chore/split docker workflows#5432

Merged
HenryHengZJ merged 2 commits intomainfrom
chore/split-docker-workflows
Nov 6, 2025
Merged

Chore/split docker workflows#5432
HenryHengZJ merged 2 commits intomainfrom
chore/split-docker-workflows

Conversation

@HenryHengZJ
Copy link
Copy Markdown
Contributor

Summary

Refactored the unified Docker image CI workflow into two separate, registry-specific workflows to simplify configuration and remove conditional logic.

Changes

  • Created docker-image-ecr.yml: Dedicated workflow for AWS ECR

    • Inputs: environment (dev/prod), node_version, tag_version
    • Always builds and pushes main image only
    • Removed registry and image_type inputs
  • Created docker-image-dockerhub.yml: Dedicated workflow for Docker Hub

    • Inputs: node_version, tag_version
    • Always builds and pushes both main and worker images
    • Removed registry, image_type, and environment inputs

Benefits

  • ✅ Simplified workflow configuration with reduced conditional logic
  • ✅ Clearer separation of concerns between registries
  • ✅ Easier to maintain and understand
  • ✅ Reduced complexity in workflow inputs

Behavior Changes

  • AWS ECR: Now always pushes main image (previously required manual selection)
  • Docker Hub: Now always pushes both main and worker images (previously required two separate runs)

Files Changed

  • Added .github/workflows/docker-image-ecr.yml
  • Added .github/workflows/docker-image-dockerhub.yml
  • Removed original docker-image.yml

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@HenryHengZJ HenryHengZJ merged commit a7b6f9b into main Nov 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant