Rely on OpenPGP.js to forbid using weak algos e.g. RSA1024 etc.#4971
Merged
Rely on OpenPGP.js to forbid using weak algos e.g. RSA1024 etc.#4971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes own protection as OpenPGP.js
config.minRSABitsimplicitly has the default value of 2047.close #4905
close #5631
Tests (delete all except exactly one):
[KeyUtil.diagnose] decrypts and tests secure PK and insecure SK[unit][OpenPGPKey.parse] sets usableForEncryption and usableForSigning to false for RSA key less than 2048[unit][OpenPGPKey.parse] sets usableForEncryption to false and usableForSigning to true for 2048/RSA PK and 1024/RSA SK[unit][OpenPGPKey.decrypt] sets usableForEncryption to false and usableForSigning to true for 2048/RSA PK and 1024/RSA SKTo be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):