Skip to content

Implement elseif#198

Merged
Flipez merged 11 commits intomainfrom
implement-elseif
Nov 27, 2023
Merged

Implement elseif#198
Flipez merged 11 commits intomainfrom
implement-elseif

Conversation

@MarkusFreitag
Copy link
Copy Markdown
Collaborator

@MarkusFreitag MarkusFreitag commented Oct 30, 2023 •
edited by Flipez
Loading

Implements if / elif / else like so:

if(false)
  puts("if")
elif(5 < 4)
  puts("else if")
else
  puts("else")
end

Blocked by the decision from issue #71

@MarkusFreitag MarkusFreitag requested a review from Flipez as a code owner October 30, 2023 22:02
@vercel
Copy link
Copy Markdown

vercel bot commented Oct 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rocket-lang ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 9:21pm
rocket-lang-play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 9:21pm

Flipez
Flipez previously approved these changes Oct 31, 2023
View reviewed changes
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0d64fb8) 87.46% compared to head (5c308df) 87.37%.

Files Patch % Lines
parser/if.go 68.42% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   87.46%   87.37%   -0.10%     
==========================================
  Files         106      106              
  Lines        3710     3731      +21     
==========================================
+ Hits         3245     3260      +15     
- Misses        398      402       +4     
- Partials       67       69       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Flipez Flipez added the enhancement New feature or request label Nov 27, 2023
@Flipez Flipez merged commit 2c802b9 into main Nov 27, 2023
@Flipez Flipez deleted the implement-elseif branch November 27, 2023 21:25
@Flipez Flipez mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flipez Flipez Flipez left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarkusFreitag @Flipez