add charge and discharge efficiencies as sensors#933
Merged
Conversation
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
* refactor: fix spelling Signed-off-by: F.N. Claessen <[email protected]> * style: missing type annotation Signed-off-by: F.N. Claessen <[email protected]> * refactor: method and variable renaming Signed-off-by: F.N. Claessen <[email protected]> * refactor: add test case explanations Signed-off-by: F.N. Claessen <[email protected]> --------- Signed-off-by: F.N. Claessen <[email protected]>
* refactor: fix spelling Signed-off-by: F.N. Claessen <[email protected]> * style: missing type annotation Signed-off-by: F.N. Claessen <[email protected]> * refactor: method and variable renaming Signed-off-by: F.N. Claessen <[email protected]> * refactor: add test case explanations Signed-off-by: F.N. Claessen <[email protected]> * fix: separate logic for falling back on a default attribute and applying a maximum capacity limit Signed-off-by: F.N. Claessen <[email protected]> * fix: fill gaps in capacity sensor data using the max_value rather than with the fallback Signed-off-by: F.N. Claessen <[email protected]> * fix: type annotation (see https://docs.python.org/3/library/typing.html#typing.Optional) Signed-off-by: F.N. Claessen <[email protected]> * refactor: clearly separate steps of falling back and performing a nanmin Signed-off-by: F.N. Claessen <[email protected]> * refactor: simplify and have get_quantity_from_attribute return a Quantity, as its name already suggested Signed-off-by: F.N. Claessen <[email protected]> * refactor: switch argument order Signed-off-by: F.N. Claessen <[email protected]> * refactor: update docstring Signed-off-by: F.N. Claessen <[email protected]> * style: flake8 Signed-off-by: F.N. Claessen <[email protected]> --------- Signed-off-by: F.N. Claessen <[email protected]>
…ery-power-capacity-as-sensor Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Base automatically changed from
feature/planning/battery-power-capacity-as-sensor
to
main
December 19, 2023 08:55
Contributor
|
@victorgarcia98 this PR became too hard to review (due to mixed contents) after the base automatically changed from |
Flix6x
reviewed
Dec 19, 2023
Contributor
Flix6x
left a comment
Flix6x
left a comment
There was a problem hiding this comment.
I managed to review a few lines of code that probably actually belong in this PR. :)
Signed-off-by: Victor Garcia Reolid <[email protected]>
This was
linked to
issues
Dec 19, 2023
…e roundtrip Signed-off-by: Victor Garcia Reolid <[email protected]>
added 2 commits
December 19, 2023 20:32
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Flix6x
approved these changes
Dec 20, 2023
Contributor
Flix6x
left a comment
Flix6x
left a comment
There was a problem hiding this comment.
Looks good. Let's add the changelog entry and the minimum required documentation (I believe in api/notation.rst and the trigger endpoint), and ship it.
nhoening
requested changes
Dec 20, 2023
Contributor
nhoening
left a comment
nhoening
left a comment
There was a problem hiding this comment.
Found two smaller errors.
added 2 commits
December 20, 2023 22:28
…efficiency-from-sensor
Signed-off-by: Victor Garcia Reolid <[email protected]>
Flix6x
approved these changes
Dec 20, 2023
Contributor
Flix6x
left a comment
Flix6x
left a comment
There was a problem hiding this comment.
Thanks for making the effort to get this in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two new fields to the
flex-model:charge-efficiencydischarge-efficiencyThese fields allow to define changing down/up efficiencies using a Sensor.