Skip to content

Fix/annotations on sensor page#1967

Merged
Flix6x merged 17 commits intomainfrom
fix/annotations-on-sensor-page
Feb 12, 2026
Merged

Fix/annotations on sensor page#1967
Flix6x merged 17 commits intomainfrom
fix/annotations-on-sensor-page

Conversation

@Flix6x
Copy link
Copy Markdown
Contributor

@Flix6x Flix6x commented Feb 9, 2026

Description

  • Fix showing chart annotations on the sensor page
  • Added changelog item in documentation/changelog.rst

Look & Feel

visualization(1)

How to test

Use flexmeasures add annotation in combination with visiting the sensor page. Annotations attributed to the sensor or its asset should be visible on the sensor page (account annotations are not).

@Flix6x Flix6x self-assigned this Feb 9, 2026
@Flix6x Flix6x added bug Something isn't working UI labels Feb 9, 2026
@nhoening
Copy link
Copy Markdown
Contributor

nhoening commented Feb 9, 2026

How do overlapping annotations look like?

Might this make it into v0.31? (as the blog author, I love visuals to go with :)

@Flix6x
Copy link
Copy Markdown
Contributor Author

Flix6x commented Feb 9, 2026

There is an old example viz incl. 2 overlapping annotations in #428.

@Flix6x Flix6x requested a review from nhoening February 9, 2026 22:54
@Flix6x Flix6x added this to the 0.31.0 milestone Feb 9, 2026
@nhoening
Copy link
Copy Markdown
Contributor

nhoening commented Feb 9, 2026

There is an old example viz incl. 2 overlapping annotations in #428.
I see 2, but they are not overlapping.

So this worked once, but has been broken for a long time? Do you know how long?

@Flix6x
Copy link
Copy Markdown
Contributor Author

Flix6x commented Feb 10, 2026

I don't. We had not actively been using annotations in over 3 years.

@nhoening
Copy link
Copy Markdown
Contributor

Here is my current view of two overlapping annotations:

image

@nhoening
Copy link
Copy Markdown
Contributor

Can we give the hovered annotation a slight highlight color (and also the annotation text below)?
That would increase UX for me. I like how the annotations are not grabbing attention when not selected, but they should grab some when selected.

@Flix6x
Copy link
Copy Markdown
Contributor Author

Flix6x commented Feb 11, 2026

vokoscreenNG-2026-02-11_16-38-07.mov

And while trying to get the highlight color to match FlexMeasures' mango secondary-color, I stumbled upon the ability to make the vega-lite color encoding match css-defined colors, which is pretty neat. So now it actually matches the secondary-color setting under the organisation account, just like for the replay button.

image

Flix6x and others added 4 commits February 11, 2026 17:12
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: Nicolas Höning <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
@Flix6x
Copy link
Copy Markdown
Contributor Author

Flix6x commented Feb 11, 2026

Small side discussion: I had a new idea to support server-level annotations (i.e. not tied to an account, asset or sensor), which would better suit, for instance, recording server maintenance slots. We would currently not be showing them (we actually don't even show account annotations right now), but just a thought. Curious to hear your opinion.

@nhoening
Copy link
Copy Markdown
Contributor

Might be useful indeed.

I dont have the perfect idea yet how to mark an annotation as such though.

Maybe when it is linked to the host account?
(we then can think about marking the host account, maybe that has other benefits)

@Flix6x
Copy link
Copy Markdown
Contributor Author

Flix6x commented Feb 11, 2026

Interesting. I just figured it could be an annotation without any links to accounts, asset or sensors. (Similar to public assets.)

Copy link
Copy Markdown
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - works great!
And the color is a great addition.

(small comment on your video: I didn't see the mouse pointer, which would have been helpful - maybe a setting in the screen recording software)

@Flix6x
Copy link
Copy Markdown
Contributor Author

Flix6x commented Feb 12, 2026

I spotted that, too, and had tried with and without the toggle button in Voko. But it doesn't work on my machine. :(

@Flix6x Flix6x merged commit a07b11a into main Feb 12, 2026
7 of 8 checks passed
@Flix6x Flix6x deleted the fix/annotations-on-sensor-page branch February 12, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants