Add support for additional-apks option#695
Merged
Merged
Conversation
jan-goral
marked this pull request as ready for review
April 5, 2020 22:47
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
============================================
+ Coverage 77.48% 77.72% +0.23%
- Complexity 642 645 +3
============================================
Files 112 112
Lines 2594 2635 +41
Branches 368 369 +1
============================================
+ Hits 2010 2048 +38
Misses 347 347
- Partials 237 240 +3 |
3 tasks
pawelpasterz
approved these changes
Apr 6, 2020
|
|
||
| private fun List<AppTestPair>.provideMissingApps(withFallbackApp: String) = | ||
| map { ResolvedTestPair(app = it.app ?: withFallbackApp, test = it.test) } | ||
| private fun AndroidArgs.getResolvedTestApks() = listOf( |
Contributor
There was a problem hiding this comment.
TBH I am not 100% convinced with styling of this method. But this is of course matter of personal preferences
bootstraponline
approved these changes
Apr 6, 2020
Contributor
|
Remember to set the ZenHub milestone/estimate/epic if there's not a linked ticket that already has this info. I updated this PR.
|
jan-goral
added
New Option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #694
Checklist