VONK-9828: Wire ValidationSettings.ModelInspector through high-level Validator POCO conversion#668
Merged
andrzejskowronski merged 2 commits intoJun 30, 2026
Conversation
Copilot
AI
changed the title
[WIP] Update ValidatorSettings to pass custom ModelInspector
VONK-9828: Wire Jun 29, 2026
ValidationSettings.ModelInspector through high-level Validator POCO conversion
andrzejskowronski
changed the base branch from
VONK-9828-FS-Update-ValidatorSettings-usage-to-pass-our-custom-ModelInspector
to
develop
June 30, 2026 08:56
andrzejskowronski
approved these changes
Jun 30, 2026
andrzejskowronski
marked this pull request as ready for review
June 30, 2026 08:57
andrzejskowronski
enabled auto-merge
June 30, 2026 08:57
andrzejskowronski
deleted the
copilot/vonk-9828-update-validator-settings-again
branch
June 30, 2026 09:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ExtensionContextValidationcould resolve model metadata via runtime-type fallback (ModelInspector.ForType), which breaks with custom model inspectors and mixed/custom type scenarios. This change makes the high-levelValidatorconsistently seed and useValidationSettings.ModelInspectorso downstream validation gets the intended inspector.Inspector propagation in
Validatorsettings.ModelInspectorwhen absent:_settings.ModelInspectorfor all high-levelToPocoNode(...)conversions:Validate(Resource ...)Validate(ElementNode ...)Behavioral guardrail
ValidationSettings.ModelInspectorwhen callers provide settings without one.Related issues
Testing
ValidatorInitializesModelInspectorOnSettingsinValidatorHighLevelApiTests.