Skip to content

VONK-9828: Wire ValidationSettings.ModelInspector through high-level Validator POCO conversion#668

Merged
andrzejskowronski merged 2 commits into
developfrom
copilot/vonk-9828-update-validator-settings-again
Jun 30, 2026
Merged

VONK-9828: Wire ValidationSettings.ModelInspector through high-level Validator POCO conversion#668
andrzejskowronski merged 2 commits into
developfrom
copilot/vonk-9828-update-validator-settings-again

Conversation

Copilot AI commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Description

ExtensionContextValidation could resolve model metadata via runtime-type fallback (ModelInspector.ForType), which breaks with custom model inspectors and mixed/custom type scenarios. This change makes the high-level Validator consistently seed and use ValidationSettings.ModelInspector so downstream validation gets the intended inspector.

  • Inspector propagation in Validator

    • Initialize settings.ModelInspector when absent:
      _settings.ModelInspector ??= ModelInfo.ModelInspector;
    • Use _settings.ModelInspector for all high-level ToPocoNode(...) conversions:
      • Validate(Resource ...)
      • Validate(ElementNode ...)
      • external reference resolution conversion path
  • Behavioral guardrail

    • Added regression coverage to assert the validator initializes ValidationSettings.ModelInspector when callers provide settings without one.

Related issues

Testing

  • Added: ValidatorInitializesModelInspectorOnSettings in ValidatorHighLevelApiTests.

Copilot AI changed the title [WIP] Update ValidatorSettings to pass custom ModelInspector VONK-9828: Wire ValidationSettings.ModelInspector through high-level Validator POCO conversion Jun 29, 2026
Copilot AI requested a review from ewoutkramer June 29, 2026 11:36
@andrzejskowronski
andrzejskowronski changed the base branch from VONK-9828-FS-Update-ValidatorSettings-usage-to-pass-our-custom-ModelInspector to develop June 30, 2026 08:56
@andrzejskowronski
andrzejskowronski marked this pull request as ready for review June 30, 2026 08:57
@andrzejskowronski
andrzejskowronski merged commit cbae79a into develop Jun 30, 2026
3 checks passed
@andrzejskowronski
andrzejskowronski deleted the copilot/vonk-9828-update-validator-settings-again branch June 30, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants