Refactored validator against PocoNode#542
Merged
Merged
Conversation
…oconode-everywhere # Conflicts: # src/Firely.Fhir.Validation/Impl/BindingValidator.cs # src/Firely.Fhir.Validation/Impl/CanonicalValidator.cs # src/Firely.Fhir.Validation/Impl/CardinalityValidator.cs # src/Firely.Fhir.Validation/Impl/ExtensionSchema.cs # src/Firely.Fhir.Validation/Impl/FhirStringValidator.cs # src/Firely.Fhir.Validation/Impl/FhirTypeLabelValidator.cs # src/Firely.Fhir.Validation/Impl/FhirUriValidator.cs # src/Firely.Fhir.Validation/Impl/FixedValidator.cs # src/Firely.Fhir.Validation/Impl/IssueAssertion.cs # src/Firely.Fhir.Validation/Impl/MaxLengthValidator.cs # src/Firely.Fhir.Validation/Impl/MinMaxValueValidator.cs # src/Firely.Fhir.Validation/Impl/PatternValidator.cs # src/Firely.Fhir.Validation/Impl/ReferencedInstanceValidator.cs # test/Firely.Fhir.Validation.Compilation.Tests.R4/TestData/issue-165/fhirpkg.lock.json # test/Firely.Fhir.Validation.Compilation.Tests.Shared/FhirTestCases # test/Firely.Fhir.Validation.Compilation.Tests.Shared/FhirTests/DotNetValidator.cs # test/Firely.Fhir.Validation.Compilation.Tests.Shared/ResourceSchemaValidationTests.cs
…oconode-everywhere # Conflicts: # test/Firely.Fhir.Validation.Compilation.Tests.Shared/FhirTestCases
…conode-everywhere # Conflicts: # src/Firely.Fhir.Validation/Impl/ExtensionContextValidator.cs # test/Firely.Fhir.Validation.Compilation.Tests.Shared/FhirTestCases # test/Firely.Fhir.Validation.Tests/Impl/ExtensionContextValidatorTests.cs
…slice requirements still remain
Kasdejong
marked this pull request as ready for review
July 8, 2025 12:10
andrzejskowronski
requested changes
Jul 8, 2025
…xed manifest, a typo snuck its way in there...
ewoutkramer
requested changes
Jul 15, 2025
andrzejskowronski
approved these changes
Jul 15, 2025
ewoutkramer
approved these changes
Jul 16, 2025
This was referenced Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored the validator to work against PocoNode instead of ITypedElement. While fixing these issues, the following issues have also been fixed:
#501
#504
Related issues
Closes #507
also review FirelyTeam/fhir-test-cases#67