Skip to content

CORE-5586#98

Merged
dyemanov merged 1 commit intoFirebirdSQL:masterfrom
cincuranet:CORE-5586
Jul 19, 2017
Merged

CORE-5586#98
dyemanov merged 1 commit intoFirebirdSQL:masterfrom
cincuranet:CORE-5586

Conversation

@cincuranet
Copy link
Copy Markdown
Member

No description provided.

Comment thread src/msgs/history2.sql
Max memory = !x
Elapsed time= !e sec', NULL, NULL, 'c_pg');
Elapsed time = !e sec', NULL, NULL, 'c_pg');
(1150, 'hvlad', '2006-02-03 19:17:10', 17, 45, 'Cpu = !u sec
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change history records :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw it there, so I played safe card. Should I remove this change?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hvlad Is there a reason to keep them?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

history2.sql contains old versions of changed messages. Formally, you should put pre-edited version of message as new record there, and never change existing records. But i really not sure it (history2.sql) is used somehow these days...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote for deleting the history file. We have VCS logs anyway.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go further and delete more things not useful, as the fields for file and function name in messages2.sql. We have grep and others tools anyway.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection fro my side, but this is offtop here ;)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So. Should I revert the history2.sql for this PR or could it stay as it's going to be deleted anyway?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert, plz.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants