Skip to content

Slightly better checking for a valid database file#8450

Merged
dyemanov merged 1 commit intomasterfrom
work/header-validation
Mar 3, 2025
Merged

Slightly better checking for a valid database file#8450
dyemanov merged 1 commit intomasterfrom
work/header-validation

Conversation

@dyemanov
Copy link
Copy Markdown
Member

  1. Validate a few more header fields before the ODS version check
  2. Check for the too small file size and report a proper error instead of I/O error

@dyemanov dyemanov self-assigned this Feb 26, 2025
@dyemanov dyemanov changed the title Slightly better checking for a valid database Slightly better checking for a valid database file Feb 26, 2025
@dyemanov dyemanov merged commit 902f8fd into master Mar 3, 2025
@pavel-zotov
Copy link
Copy Markdown

::: QA note :::
Have an issue about FB crashes when invalid DB is a file with size from 1024 to 8191 bytes.
Sent example to dimitr, waiting for reply.

dyemanov added a commit that referenced this pull request Nov 29, 2025
…vents crashes for files >= 1KB but < PAGE_SIZE.
@mrotteveel mrotteveel added the rlsnotes60: yes Already added to the Firebird 6.0 release notes. (Do not add this to signal it should be added.) label Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: engine fix-version: 6.0 Alpha 1 qa: deferred rlsnotes60: yes Already added to the Firebird 6.0 release notes. (Do not add this to signal it should be added.) type: improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants