Make server to correctly handle case when accept() returns both success and data for client.#8262
Merged
hvlad merged 1 commit intov5.0-releasefrom Sep 23, 2024
Merged
Make server to correctly handle case when accept() returns both success and data for client.#8262hvlad merged 1 commit intov5.0-releasefrom
hvlad merged 1 commit intov5.0-releasefrom
Conversation
…ss and data for client.
AlexPeshkoff
approved these changes
Sep 23, 2024
hvlad
added a commit
that referenced
this pull request
Sep 24, 2024
Make server to correctly handle case when accept() returns both success and data for client.
hvlad
added a commit
that referenced
this pull request
Sep 24, 2024
Make server to correctly handle case when accept() returns both success and data for client.
mrotteveel
added
the
rlsnotes60: no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When security package was changed from NTLM to Negotiate (see #8256), the last call of
AcceptSecurityContext()returns SEC_E_OK and some data for client. Server should send its to the client, but it doesn't. As result, client can't obtain encryption key from security context and wire encryption is not possible.This is the reason for failure of QA test for #6204.