Skip to content

Fix boolean conversion to string inside DataTypeUtil::makeFromList()#8178

Merged
dyemanov merged 1 commit intov5.0-releasefrom
boolean-make-from-list
Jul 10, 2024
Merged

Fix boolean conversion to string inside DataTypeUtil::makeFromList()#8178
dyemanov merged 1 commit intov5.0-releasefrom
boolean-make-from-list

Conversation

@dyemanov
Copy link
Copy Markdown
Member

@dyemanov dyemanov commented Jul 10, 2024

Pre-check:

SQL> select coalesce(123, 'asd') from rdb$database;

COALESCE    
=========== 
123         

SQL> select coalesce('asd', 123) from rdb$database;

COALESCE    
=========== 
asd         

SQL> select coalesce('asd', true) from rdb$database;

COALESCE 
======== 
asd      

SQL> select coalesce(true, 'asd') from rdb$database;

COALESCE 
======== 
TRUE     

SQL> select coalesce(123, true) from rdb$database;
Statement failed, SQLSTATE = HY004
SQL error code = -104
-Datatypes are not comparable in expression COALESCE

SQL> select coalesce(true, 123) from rdb$database;
Statement failed, SQLSTATE = HY004
SQL error code = -104
-Datatypes are not comparable in expression COALESCE

Everything is expected so far. Now execute this:

SQL> select coalesce('asd', true, 123) from rdb$database;

COALESCE    
=========== 
asd         

SQL> select coalesce('asd', 123, true) from rdb$database;

COALESCE    
=========== 
asd         

SQL> select coalesce(true, 'asd', 123) from rdb$database;

COALESCE    
=========== 
TRUE       

SQL> select coalesce(true, 123, 'asd') from rdb$database;

COALESCE    
=========== 
TRUE        

SQL> select coalesce(123, 'asd', true) from rdb$database;

COALESCE    
=========== 
123         

SQL> select coalesce(123, true, 'asd') from rdb$database;
Statement failed, SQLSTATE = HY004
SQL error code = -104
-Datatypes are not comparable in expression COALESCE

The last error is not expected and this is wrong accordingly to the rules inside DataTypeUtil::makeFromList():

// The output type is figured out as based on this order:
// 1) If any datatype is blob, returns blob;
// 2) If any datatype is a) varying or b) any text/cstring and another datatype, returns varying;
// 3) If any datatype is text or cstring, returns text;

The expected result is to return '123' and this patch fixes this issue (expected errors in the pre-check above are still raised).

@dyemanov dyemanov self-assigned this Jul 10, 2024
@dyemanov dyemanov requested a review from asfernandes July 10, 2024 08:46
@dyemanov dyemanov merged commit 56fe91a into v5.0-release Jul 10, 2024
dyemanov added a commit that referenced this pull request Jul 10, 2024
@dyemanov
Fix boolean conversion to string inside DataTypeUtil::makeFromList() (#…
adf19fc 
…8178)
dyemanov added a commit that referenced this pull request Jul 10, 2024
@dyemanov
Fix boolean conversion to string inside DataTypeUtil::makeFromList() (#…
4e26d0a 
…8178)
dyemanov added a commit that referenced this pull request Jul 10, 2024
@dyemanov
Fix boolean conversion to string inside DataTypeUtil::makeFromList() (#…
e142162 
…8178)
dyemanov added a commit that referenced this pull request Nov 16, 2024
@dyemanov
Fix boolean conversion to string inside DataTypeUtil::makeFromList() (#…
2e15651 
…8178)
@mrotteveel mrotteveel added the rlsnotes60: no Intentionally not added to the Firebird 6.0 release notes. label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asfernandes asfernandes asfernandes approved these changes

Assignees

@dyemanov dyemanov

Labels

affect-version: 3.0.11 affect-version: 4.0.4 affect-version: 5.0.0 affect-version: 6.0 Initial component: engine fix-version: 3.0.12 fix-version: 4.0.5 fix-version: 5.0.1 fix-version: 6.0 Alpha 1 qa: done successfully rlsnotes60: no Intentionally not added to the Firebird 6.0 release notes. type: bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dyemanov @asfernandes @mrotteveel @pavel-zotov