Simplest fix for bug #8120 : Cast dies with numeric value is out of range error (5.0.1 snapshot)#8129
Merged
Simplest fix for bug #8120 : Cast dies with numeric value is out of range error (5.0.1 snapshot)#8129
Conversation
…ange error (5.0.1 snapshot)
AlexPeshkoff
approved these changes
May 24, 2024
Member
|
Out of curiosity, why does the introduction of those braces fix this problem? |
Member
Author
It set scope for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem in #8120 is that
RetValueupdatesvaluein own destructor only, thus making impossible to work withvaluein the same scope asRetValue.I found and fixed two occurrences of such code but it looks as fragile to me.
It would be better to not create such indirect dependencies, for example moving
RetValueinstance intocvt_decompose().