Fix for #8105: Master database could miss replication segments on Windows Classic Server#8106
Merged
hvlad merged 3 commits intov4.0-releasefrom May 8, 2024
Merged
Fix for #8105: Master database could miss replication segments on Windows Classic Server#8106hvlad merged 3 commits intov4.0-releasefrom
hvlad merged 3 commits intov4.0-releasefrom
Conversation
Fixed problem with renaming segments files when reusing segments.
dyemanov
reviewed
May 8, 2024
dyemanov
reviewed
May 8, 2024
Removed not used g_dummyHeader.
dyemanov
approved these changes
May 8, 2024
hvlad
added a commit
that referenced
this pull request
May 8, 2024
Fix for #8105: Master database could miss replication segments on Windows Classic Server
hvlad
added a commit
that referenced
this pull request
May 8, 2024
Fix for #8105: Master database could miss replication segments on Windows Classic Server
dyemanov
pushed a commit
that referenced
this pull request
Nov 16, 2024
Fix for #8105: Master database could miss replication segments on Windows Classic Server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main problem is that on Windows it is not allowed to rename open files with mapped memory section.
rename()for such file always seterrnotoEACCES,GetLastError()returnsERROR_SHARING_VIOLATION.