Fixed bug #7927 : Some default values is set incorrectly for SC\CS architectures#7929
Merged
hvlad merged 1 commit intov4.0-releasefrom Dec 20, 2023
Merged
Fixed bug #7927 : Some default values is set incorrectly for SC\CS architectures#7929hvlad merged 1 commit intov4.0-releasefrom
hvlad merged 1 commit intov4.0-releasefrom
Conversation
asfernandes
reviewed
Dec 19, 2023
| defaults[KEY_REMOTE_FILE_OPEN_ABILITY].boolVal = bootBuild; | ||
| if (pValue->intVal < 0) | ||
| pValue->intVal = pDefault->intVal; | ||
|
|
Member
There was a problem hiding this comment.
Two blank lines inside a function body looks excessive (per function separation in this file is one line).
Member
Author
There was a problem hiding this comment.
It allows to visually separate handling of each key.
I can change blank line by additional comment, but will it be better ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.