Fix an issue where the garbage collection in indexes and blobs is not performed in VIO_backout#7747
Merged
ilya071294 merged 1 commit intoFirebirdSQL:masterfrom Sep 14, 2023
Conversation
… performed in VIO_backout The issue starts in VIO_record. There is a call record->reset(format) which clears the REC_gc_active flag by mistake. After that VIO_gc_record reuses the record which is already active.
dyemanov
approved these changes
Sep 14, 2023
ilya071294
added a commit
that referenced
this pull request
Sep 14, 2023
…and blobs is not performed in VIO_backout The issue starts in VIO_record. There is a call record->reset(format) which clears the REC_gc_active flag by mistake. After that VIO_gc_record reuses the record which is already active.
ilya071294
added a commit
that referenced
this pull request
Sep 14, 2023
…and blobs is not performed in VIO_backout The issue starts in VIO_record. There is a call record->reset(format) which clears the REC_gc_active flag by mistake. After that VIO_gc_record reuses the record which is already active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue:
no auto undoand rollback.gstat -rto see that we have 2 record versions (total records: 1, total versions: 1), 2 blobs (Blobs: 2) and 2 index nodes (nodes: 2).selectto trigger the garbage collection:gstat -ragain and see that the uncommitted record version is deleted (total versions: 0), but the amount of blobs and index nodes remained unchanged (Blobs: 2, nodes: 2).The issue starts in
VIO_record. There is a callrecord->reset(format)which clears theREC_gc_activeflag by mistake. After thatVIO_gc_recordreuses the record which is already active.