Cache sort blocks by the sort owners to avoid contention in shared cache of sorts blocks.#7671
Merged
Cache sort blocks by the sort owners to avoid contention in shared cache of sorts blocks.#7671
Conversation
dyemanov
reviewed
Jul 10, 2023
dyemanov
reviewed
Jul 10, 2023
dyemanov
approved these changes
Jul 10, 2023
Member
dyemanov
left a comment
dyemanov
left a comment
There was a problem hiding this comment.
Approved with a couple of minor comments.
hvlad
added a commit
that referenced
this pull request
Apr 2, 2024
…e from backup (FB5, RC2) Don't use common SortOwner for sorts with different dbb's. After #7671 it could contain cached sort buffers from different pools (dbb_permanent) and then release it to the wrong dbb_sort_buffers making possible usage of deallocated memory later.
hvlad
added a commit
that referenced
this pull request
Apr 3, 2024
…e from backup (FB5, RC2) Don't use common SortOwner for sorts with different dbb's. After #7671 it could contain cached sort buffers from different pools (dbb_permanent) and then release it to the wrong dbb_sort_buffers making possible usage of deallocated memory later.
dyemanov
pushed a commit
that referenced
this pull request
Nov 16, 2024
…e from backup (FB5, RC2) Don't use common SortOwner for sorts with different dbb's. After #7671 it could contain cached sort buffers from different pools (dbb_permanent) and then release it to the wrong dbb_sort_buffers making possible usage of deallocated memory later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If request performs many sorts while executing, it often uses shared cache of sort blocks (maintained at dbb-level).
When such requests run concurrently, its creates a big load on shared cache and wait for each other significant time, reducing common performance.
This problem present at SS architecture only.
The offered solution is to avoid return of used sort block into shared common cache until requiest finished its execution.