Skip to content

Change release filenames as the following examples#7284

Merged
asfernandes merged 6 commits intomasterfrom
work/release-filenames
Sep 6, 2022
Merged

Change release filenames as the following examples#7284
asfernandes merged 6 commits intomasterfrom
work/release-filenames

Conversation

@asfernandes
Copy link
Copy Markdown
Member

@asfernandes asfernandes commented Aug 30, 2022 

Firebird-<version number>-<package number>-windows-x86-withDebugSymbols.exe
Firebird-<version number>-<package number>-windows-x86-withDebugSymbols.zip
Firebird-<version number>-<package number>-windows-x86.exe
Firebird-<version number>-<package number>-windows-x86.zip
Firebird-<version number>-<package number>-windows-x64-withDebugSymbols.exe
Firebird-<version number>-<package number>-windows-x64-withDebugSymbols.zip
Firebird-<version number>-<package number>-windows-x64.exe
Firebird-<version number>-<package number>-windows-x64.zip
Firebird-<version number>-<package number>-linux-x64.tar.gz
Firebird-<version number>-<package number>-linux-x64-debugSymbols.tar.gz
Firebird-<version number>-<package number>-android-arm.tar.gz (armv7, other?)
Firebird-<version number>-<package number>-android-arm-withDebugSymbols.tar.gz
Firebird-<version number>-<package number>-android-arm64.tar.gz
Firebird-<version number>-<package number>-android-arm64-withDebugSymbols.tar.gz
Firebird-<version number>-<package number>-linux-x86.tar.gz
Firebird-<version number>-<package number>-linux-x86-debugSymbols.tar.gz
Firebird-<version number>-<package number>-macos-x64.pkg
Firebird-<version number>-<package number>-macos-arm64.pkg
Firebird-<version number>-<package number>-source.tar.xz

@asfernandes asfernandes self-assigned this Aug 30, 2022
@reevespaul reevespaul self-requested a review August 30, 2022 12:30
@asfernandes
Copy link
Copy Markdown
Member Author

asfernandes commented Sep 5, 2022

@reevespaul are you going to review this soon?

I'll soon have Android build changes that depends on this.

@reevespaul
Copy link
Copy Markdown
Contributor

reevespaul commented Sep 6, 2022

I'm sorry, I did not realise you were waiting for a reply from me.

The proposed changes for windows filenames are OK for me.

Has anyone raised the question why the linux files names use just 'debugSymbols' when all the other platforms use 'withDebugSymbols' ?

@asfernandes
Copy link
Copy Markdown
Member Author

asfernandes commented Sep 6, 2022

Has anyone raised the question why the linux files names use just 'debugSymbols' when all the other platforms use 'withDebugSymbols' ?

As said in firebird-devel, -debugSymbols contains only debug symbols, -withDebugSymbols contains full release with debug symbols.

@asfernandes asfernandes merged commit 14fc962 into master Sep 6, 2022
@asfernandes asfernandes deleted the work/release-filenames branch September 6, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reevespaul reevespaul Awaiting requested review from reevespaul

Assignees

@asfernandes asfernandes

Labels

affect-version: 5.0 Initial component: build issues / porting fix-version: 5.0 Beta 1 type: improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asfernandes @reevespaul