Add table MON$COMPILED_STATEMENTS and columns#7050
Conversation
…ILED_STATEMENT_ID and MON$CALL_STACK.MON$COMPILED_STATEMENT_ID.
|
While not required, I have made the first request incarnation to use the same ID of the statement. Statement and request IDs shares the same counter. |
|
Here is a test I used: |
|
Can this afffect performance in bad/good way? Or this is only preparation for some future feature? |
|
This only put more information in |
|
Anyone see problem in merge this in master? |
|
|
||
| // Generate request id. | ||
| request->setRequestId( | ||
| request->isRequestIdUnassigned() && statement->requests.hasData() && request == statement->requests[0] ? |
There was a problem hiding this comment.
This part (statement->requests.hasData() && request == statement->requests[0]) is quite longish and repeated twice across the code. Maybe encapsulate it into something like bool Statement::isRootRequest(jrd_req request) const or probably bool jrd_req::isRoot() const? "Root" could be replaced with "Initial" or whatever.
dyemanov
left a comment
There was a problem hiding this comment.
I don't have any objections after review.
MON$STATEMENTS.MON$COMPILED_STATEMENT_ID and MON$CALL_STACK.MON$COMPILED_STATEMENT_ID.
Request ID is incremented every time it's started.