Fix CORE-5223#19
Merged
dyemanov merged 2 commits intoFirebirdSQL:masterfrom May 15, 2016
Merged
Conversation
| { | ||
| continue; | ||
| } | ||
| if (elem == PathUtils::up_dir_link) // skip next up dir |
Member
There was a problem hiding this comment.
Does FB still run (compiles for) in Win 9X based kernels? I do remember in this OS "..." (or more dots) was valid part of paths, meaning "...." and so. Is this compatible? Or is the old code (2.X) compatible with this?
Contributor
Author
There was a problem hiding this comment.
AFAIR, Firebird doesn't support Win9X anymore.
Neither Windows 8 nor Linux support three dots in path.
Contributor
|
To be more precise, "..." is a valid name for a directory or a file in Linux, it doesn't have any special meaning: |
| { | ||
| continue; | ||
| } | ||
| if (elem == ".") // Skip current dir reference |
Member
There was a problem hiding this comment.
Worth adding PathUtils::curr_dir_link, I believe.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little more clever parsing of path allow to use double dots in names but still avoid "up dir hack".