Add window functions, PERCENT_RANK(), CUME_DIST() and NTILE().#16
Merged
asfernandes merged 1 commit intoFirebirdSQL:masterfrom Jun 29, 2016
nakagami:new_window_functions
Merged
Add window functions, PERCENT_RANK(), CUME_DIST() and NTILE().#16asfernandes merged 1 commit intoFirebirdSQL:masterfrom nakagami:new_window_functions
asfernandes merged 1 commit intoFirebirdSQL:masterfrom
nakagami:new_window_functions
Conversation
Contributor
nakagami
commented
Apr 17, 2016
- PERCENT_RANK http://tracker.firebirdsql.org/browse/CORE-3616
- CUME_DIST http://tracker.firebirdsql.org/browse/CORE-3617
- NTILE http://tracker.firebirdsql.org/browse/CORE-3618
Member
|
@nakagami I believe it's better to add recordCount to SlidingWindow instead of pass it as win_row_count in winPass method. Next we may see if we can pass SlidingWindow in aggExecute too. Can you please do the first change? |
Member
|
@nakagami please let the structure changes for me. But your functions are producing different results than Oracle and PgSQL. Please see this: Oracle / PgSQL: Firebird: |
Contributor
Author
|
Sorry I don't have enogh time now. But I will see this issue. Please wait |
Member
|
I committed this pull request with many changes to fix the mentioned bugs. Please test it. |
Contributor
Author
|
Oh, sorry and thank you so much ! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.