Fixed CORE-6486 and CORE-6487 with one shot

dyemanov · dyemanov · commit f2fc97acadcf · 2021-02-16T13:04:47.000+03:00
diff --git a/src/jrd/recsrc/Cursor.cpp b/src/jrd/recsrc/Cursor.cpp
@@ -281,8 +281,10 @@ bool Cursor::fetchAbsolute(thread_db* tdbb, SINT64 offset) const
 		return false;
 	}
 
-	const BufferedStream* const buffer = static_cast<const BufferedStream*>(m_top);
-	impure->irsb_position = (offset > 0) ? offset - 1 : buffer->getCount(tdbb) + offset;
+	const auto buffer = static_cast<const BufferedStream*>(m_top);
+	const auto count = buffer->getCount(tdbb);
+
+	impure->irsb_position = (offset > 0) ? offset - 1 : count + offset;
 	buffer->locate(tdbb, impure->irsb_position);
 
 	if (!buffer->getRecord(tdbb))
@@ -323,18 +325,28 @@ bool Cursor::fetchRelative(thread_db* tdbb, SINT64 offset) const
 		return (impure->irsb_state == POSITIONED);
 	}
 
-	if (impure->irsb_state == BOS && offset < 0)
+	const auto buffer = static_cast<const BufferedStream*>(m_top);
+	const auto count = buffer->getCount(tdbb);
+
+	if (impure->irsb_state == BOS)
 	{
-		return false;
+		if (offset < 0)
+			return false;
+
+		impure->irsb_position = offset - 1;
 	}
+	else if (impure->irsb_state == EOS)
+	{
+		if (offset > 0)
+			return false;
 
-	if (impure->irsb_state == EOS && offset > 0)
+		impure->irsb_position = count + offset;
+	}
+	else
 	{
-		return false;
+		impure->irsb_position += offset;
 	}
 
-	const BufferedStream* const buffer = static_cast<const BufferedStream*>(m_top);
-	impure->irsb_position += offset;
 	buffer->locate(tdbb, impure->irsb_position);
 
 	if (!buffer->getRecord(tdbb))
