Adding '--force' argument#424
Merged
bkendall merged 10 commits intoFirebaseExtended:mainfrom Aug 15, 2025
Merged
Conversation
…e your bill, such as minimum instances required.
|
@mbleigh @jamesdaniels @paulb777 much needed addition! |
|
can someone approve this, thanks |
|
PLEASE APPROVE THIS!!!!!! |
|
please approve this. |
bkendall
requested changes
Aug 12, 2025
Co-authored-by: Bryan Kendall <[email protected]>
…port for channel site deployment with force flag. Updated tests to and types to account for force flags. Force flag is now optional on ProductionDeployConfig and ChannelDeployConfig. Simplified deploy calls using force flag to automatically append force based on the boolean value nad removed the force-specific branch in index.ts
Collaborator
|
Alright, sorry for the churn, but it turns out that the tests on main have been broken a while. I've updated
(oh, and of course, |
bkendall
requested changes
Aug 14, 2025
Collaborator
bkendall
left a comment
There was a problem hiding this comment.
Last bit, but everything looks good.
bkendall
approved these changes
Aug 15, 2025
jhuleatt
approved these changes
Aug 15, 2025
Collaborator
jhuleatt
left a comment
There was a problem hiding this comment.
Thank you @ThadCastl3!
Collaborator
|
I'll work on releasing this on Monday since we don't typically release on Fridays. Thanks for the work @ThadCastl3 |
Contributor
Author
|
I noticed we didn't update the readme but could just throw this in:
Bypass the confirmation prompt.` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request introduces a new
--forceflag for Firebase deployments, enabling users to force deploy changes that may increase their billing, such as deploying more than 0 minimum instances of a function. The changes include updates to the deployment logic, input handling, and test coverage.Reasoning:
Enhancements to Deployment Functionality:
forceinput inaction.ymlto accept the--forceflag for deployments. This input is optional and defaults tofalse.deployWithForcefunction insrc/deploy.tsto handle deployments with the--forceflag, including parsing its result.deployPreviewanddeployProductionSite) to support theforceoption in their configurations. [1] [2]Codebase Updates for
--forceSupport:execWithCredentialsinsrc/deploy.tsto append the--forceflag to Firebase CLI commands when theforceoption is enabled. [1] [2]src/index.tsto retrieve theforceinput, pass it to deployment functions, and handle deployments with theforceflag if specified. [1] [2] [3]Test Coverage Improvements:
test/deploy.test.tsto validate that the--forceflag is correctly included in deployment commands when enabled.forceDeploySingleSiteSuccesssample intest/samples/cliOutputs.tsto simulate successful deployments with the--forceflag.Documentation and Cleanup:
action.ymlinto single-line format for better readability.updated for Google CLA