Skip to content

Updated dependencies to fix set-output warning#279

Merged
jhuleatt merged 1 commit intoFirebaseExtended:mainfrom
yurist38:update-deps
May 16, 2023
Merged

Updated dependencies to fix set-output warning#279
jhuleatt merged 1 commit intoFirebaseExtended:mainfrom
yurist38:update-deps

Conversation

@yurist38
Copy link
Copy Markdown
Contributor

Hello,

I've noticed this warning in my CI output, and I'm pretty confident it's coming from this action.
This PR is an attempt to fix it, but I didn't test it myself yet.
I've simply upgraded all dependencies and fixed a couple of small things in the GitHub CLI in order to make it work again.

Screenshot 2023-04-22 at 16 18 40

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@yurist38 yurist38 changed the title Updated dependencies and formatted Updated dependencies to fix set-output warning Apr 22, 2023
@f0urfingeredfish
Copy link
Copy Markdown

@jhuleatt could we get some traction on this please? This action seems really popular and it will stop working on June 1st, 2023 unless fixed.

JaffaKetchup added a commit to fleaflet/flutter_map that referenced this pull request May 12, 2023
Uses Firebase Hosting & https://github.com/FirebaseExtended/action-hosting-deploy to build and deploy the example app on web.
Creates preview sites for PRs, and deploys to the live site on pushes to the master branch.

We're looking for FirebaseExtended/action-hosting-deploy#279 to be merged by 2023/05/31.
We're looking for axel-op/dart-package-analyzer#22 to be resolved by 2023/05/31.
Otherwise, this action will fail (note that the existing action will fail by this date currently anyway).
@NKalganov
Copy link
Copy Markdown

@jhuleatt could you please merge this branch? We have only two weeks left before the main branch becomes outdated without this update. Thank you in advance! 🙏

@jhuleatt
Copy link
Copy Markdown
Collaborator

Thank you @yurist38! Really appreciate this!

@jhuleatt jhuleatt merged commit 638d3c1 into FirebaseExtended:main May 16, 2023
@yurist38
Copy link
Copy Markdown
Contributor Author

Awesome! Thank you for reviewing and merging this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Successful action reporting as failed due to GitHub 'set-output' deprecation warning

4 participants