Skip to content

Add entryPoint option#16

Merged
jhuleatt merged 12 commits intomainfrom
add-entrypoint-option
Sep 9, 2020
Merged

Add entryPoint option#16
jhuleatt merged 12 commits intomainfrom
add-entrypoint-option

Conversation

@jhuleatt
Copy link
Copy Markdown
Collaborator

@jhuleatt jhuleatt commented Sep 9, 2020 •
edited
Loading

Fixes #16

Adds an entryPoint option to allow for firebase.json files that aren't in the repository's root.

The name entryPoint was chosen to feel similar to a workflow file's entrypoint, which doesn't work with JS Actions, but also maintain camel case to match the other options for this Action.

Example:

action-hosting-deploy/.github/workflows/deploy-preview.yml

Lines 26 to 31 in 350fcd4

with:
repoToken: "${{ secrets.GITHUB_TOKEN }}"
firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT }}"
expires: 30d
projectId: action-hosting-deploy-demo
entryPoint: "./demo"

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 9, 2020 •
edited
Loading

Deploy preview for 846da00:

https://action-hosting-deploy-demo--pr16-add-entrypoint-optio-daecu2og.web.app

(expires Wed, 16 Sep 2020 23:32:54 GMT)

firebase-hosting-preview-action

@googlebot googlebot added the cla: yes Contributor has signed CLA label Sep 9, 2020
@jhuleatt jhuleatt merged commit 577db06 into main Sep 9, 2020
davideast
davideast reviewed Sep 10, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jhuleatt jhuleatt mentioned this pull request Sep 25, 2020
Closed
pomle pushed a commit to pomle/action-hosting-deploy that referenced this pull request Nov 8, 2020
@jhuleatt
Add entryPoint option (FirebaseExtended#16)
d703bec
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davideast davideast davideast left review comments

@kroikie kroikie Awaiting requested review from kroikie

Assignees

No one assigned

Labels

cla: yes Contributor has signed CLA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhuleatt @davideast @googlebot