Ensure a normalized URL is printed#13
Merged
jhuleatt merged 1 commit intoFirebaseExtended:mainfrom Sep 9, 2020
Merged
Conversation
`https://example.tld` is not a normalized URL, but `https://example.tld/` (note the slash following the origin) is. ```js new URL('https://example.tld').toString() === 'https://example.tld/' ``` This patch ensures a normalized URL is used in the GitHub comment. Drive-by fix: fix /n → \n typo.
jhuleatt
approved these changes
Sep 9, 2020
Collaborator
jhuleatt
left a comment
jhuleatt
left a comment
There was a problem hiding this comment.
Thanks @mathiasbynens!
pomle
pushed a commit
to pomle/action-hosting-deploy
that referenced
this pull request
Nov 8, 2020
Ensure a normalized URL is printed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://example.tldis not a normalized URL, buthttps://example.tld/(note the slash following the origin) is.This patch ensures a normalized URL is used in the GitHub comment.
Drive-by fix: fix /n → \n typo.