Skip to content

Add jdk11 compat tests for Blackbird cross-classloader access#10

Merged
cowtowncoder merged 1 commit intoFasterXML:masterfrom
stevenschlansker:blackbird-compat
Jan 4, 2022
Merged

Add jdk11 compat tests for Blackbird cross-classloader access#10
cowtowncoder merged 1 commit intoFasterXML:masterfrom
stevenschlansker:blackbird-compat

Conversation

@stevenschlansker
Copy link
Copy Markdown
Contributor

@stevenschlansker stevenschlansker commented Jan 4, 2022

This test fails until the issue is fixed in Blackbird.
FasterXML/jackson-modules-base#138
FasterXML/jackson-modules-base#162

Note: I am currently not able to complete a Maven build of this project, even before changing anything I end up with:

[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ jdk11-tests ---
[INFO] Toolchain in maven-compiler-plugin: JDK[/usr/lib/jvm/java-11]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Jackson-JDK11-compat-test 2.12.0-rc2:
[INFO] 
[INFO] Jackson-JDK11-compat-test .......................... SUCCESS [  1.096 s]
[INFO] jdk11-tests ........................................ FAILURE [  0.336 s]
[INFO] jackson-jlink ...................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project jdk11-tests: Execution default-compile of goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile failed: Unsupported major.minor version 61.0 -> [Help 1]

Are you able to build?

@stevenschlansker stevenschlansker mentioned this pull request Jan 4, 2022
Merged
@GedMarc
Copy link
Copy Markdown
Collaborator

GedMarc commented Jan 4, 2022

I do have a fairly big update coming in for JDK 17 support as well - the version and release of the jakarta artifacts to official distributions being one (resolving the build issue)

I'll bump this up a bit to get it in quicker for you - Also check your jackson version there, 2.12.0-rc2 ;)

THANKS FOR THE PR!!!!

@stevenschlansker
Copy link
Copy Markdown
Contributor Author

stevenschlansker commented Jan 4, 2022

Thanks @GedMarc, that sounds great! Yes, 2.12.0-rc2 does seem wrong, but that is not my change. it is that way on master branch: https://github.com/FasterXML/jackson-jdk11-compat-test/blob/master/pom.xml#L13

@GedMarc
Copy link
Copy Markdown
Collaborator

GedMarc commented Jan 4, 2022

yeah i know :'( i've really let this one slip

@cowtowncoder
Copy link
Copy Markdown
Member

cowtowncoder commented Jan 4, 2022

We probably also need to start using maintenance branches etc. Will merge this first tho.

@cowtowncoder cowtowncoder merged commit 966c7c5 into FasterXML:master Jan 4, 2022
@cowtowncoder
Copy link
Copy Markdown
Member

cowtowncoder commented Jan 4, 2022

Ok I changed versions to 2.13.2-SNAPSHOT but I think there's now one 2.12 vs 2.13 issue -- latter moved away from jakarta classifier for JAX-vs-Jakarta difference. So that needs to be resolved somehow.

@stevenschlansker stevenschlansker deleted the blackbird-compat branch January 4, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stevenschlansker @GedMarc @cowtowncoder