README.md (1)

15-17: Documentation link is a good addition.

Prominently placing the full documentation link near the top improves discoverability.

Minor nit: There appear to be two consecutive blank lines (16 and 17) before the next content block. Consider removing one for consistency with the rest of the file's formatting.

✨ Suggested fix

 📚 **[View the Full Documentation](https://faserf.github.io/ha-db_infoscreen/)**
 
-
 <div align="center">

custom_components/db_infoscreen/config_flow.py (1)

62-65: Consider accepting both “,” and “|” for via-station input.

Line 62 and Line 215 now split only on commas; users accustomed to | will end up with a single entry. Supporting both separators preserves backward compatibility.

🔧 Possible tweak

-            user_input[CONF_VIA_STATIONS] = [
-                s.strip() for s in via_raw.split(",") if s.strip()
-            ]
+            user_input[CONF_VIA_STATIONS] = [
+                s.strip() for s in re.split(r"[|,]", via_raw) if s.strip()
+            ]
@@
-                user_input[CONF_VIA_STATIONS] = [
-                    s.strip() for s in via_raw.split(",") if s.strip()
-                ]
+                user_input[CONF_VIA_STATIONS] = [
+                    s.strip() for s in re.split(r"[|,]", via_raw) if s.strip()
+                ]

Also applies to: 215-217

tests/test_sensor.py (1)

41-63: test_sensor_setup is a no-op right now.

Lines 41–63 end with pass; consider skipping or removing to avoid misleading coverage.

🧹 Optional cleanup

 async def test_sensor_setup(hass: HomeAssistant):
     """Test setting up the sensor."""
+    pytest.skip("Setup flow is covered by integration tests")
@@
-    pass

.github/workflows/backend-api-update.yml (1)

41-50: Consider adding error handling for the comment action.

If .backend_version doesn't exist or is empty, the script will post a comment with an undefined/empty version. Consider adding a guard.

🛡️ Suggested improvement

          script: |
            const fs = require('fs');
            const version = fs.readFileSync('.backend_version', 'utf8').trim();
+           
+           if (!version) {
+             core.warning('Backend version is empty');
+             return;
+           }

            github.rest.issues.createComment({

tests/test_translations.py (1)

33-45: Consider using isinstance() and handling list values.

Two observations:

1. Line 38 uses type(x) is dict which doesn't account for dict subclasses. Prefer isinstance(x, dict).
2. The function silently ignores list values in the JSON structure. If any translation values are arrays, they won't be flattened or compared.

♻️ Suggested improvement

 def flatten_json(y):
     """Flatten a nested json dict."""
     out = {}

     def flatten(x, name=""):
-        if type(x) is dict:
+        if isinstance(x, dict):
             for a in x:
                 flatten(x[a], name + a + ".")
+        elif isinstance(x, list):
+            for i, item in enumerate(x):
+                flatten(item, name + str(i) + ".")
         else:
             out[name[:-1]] = x

     flatten(y)
     return out

custom_components/db_infoscreen/sensor.py (1)

69-132: Consider dt_util.parse_datetime for string timestamps to handle offsets.

Manual strptime won’t parse strings with timezone offsets (e.g., ...Z, +01:00) and produces naive datetimes. Using dt_util.parse_datetime (and localizing if tzinfo is missing) would make parsing more robust and cut down the format cascade.

♻️ Illustrative refactor for the string branch

-        elif isinstance(departure_time, str):
-            try:
-                departure_time = datetime.strptime(departure_time, "%Y-%m-%d %H:%M:%S")
-                _LOGGER.debug(
-                    "Converted departure time from string: %s", departure_time
-                )
-            except ValueError:
-                try:
-                    departure_time = datetime.strptime(
-                        departure_time, "%Y-%m-%dT%H:%M:%S"
-                    )
-                    _LOGGER.debug(
-                        "Converted departure time from ISO string: %s", departure_time
-                    )
-                except ValueError:
-                    try:
-                        departure_time = datetime.strptime(
-                            departure_time, "%Y-%m-%dT%H:%M"
-                        )
-                        _LOGGER.debug(
-                            "Converted departure time from ISO short string: %s",
-                            departure_time,
-                        )
-                    except ValueError:
-                        ...
+        elif isinstance(departure_time, str):
+            parsed = dt_util.parse_datetime(departure_time)
+            if parsed is not None:
+                if parsed.tzinfo is None:
+                    parsed = parsed.replace(tzinfo=dt_util.DEFAULT_TIME_ZONE)
+                departure_time = dt_util.as_local(parsed)
+                _LOGGER.debug("Converted departure time from string: %s", departure_time)
+            else:
+                ...

custom_components/db_infoscreen/sensor.py (1)

220-229: Inconsistent timezone handling with datetime.fromtimestamp().

The format_departure_time method was updated to use dt_util helpers for timezone-aware handling, but extra_state_attributes still uses bare datetime.fromtimestamp() which produces naive datetimes in the local system timezone. For consistency and robustness, consider using the same approach here.

♻️ Suggested refactor for consistency

             if "scheduledTime" in dep_copy and isinstance(
                 dep_copy["scheduledTime"], int
             ):
-                dep_copy["scheduledTime"] = datetime.fromtimestamp(
-                    dep_copy["scheduledTime"]
-                ).strftime("%Y-%m-%d %H:%M:%S")
+                dep_copy["scheduledTime"] = dt_util.as_local(
+                    dt_util.utc_from_timestamp(dep_copy["scheduledTime"])
+                ).strftime("%Y-%m-%d %H:%M:%S")
             if "time" in dep_copy and isinstance(dep_copy["time"], int):
-                dep_copy["time"] = datetime.fromtimestamp(dep_copy["time"]).strftime(
-                    "%Y-%m-%d %H:%M:%S"
-                )
+                dep_copy["time"] = dt_util.as_local(
+                    dt_util.utc_from_timestamp(dep_copy["time"])
+                ).strftime("%Y-%m-%d %H:%M:%S")

custom_components/db_infoscreen/__init__.py (2)

211-216: Inconsistent URL encoding for via_stations.

The main station encoding (lines 125-129) converts + to %20 for proper URL encoding of spaces, but via_stations uses quote_plus() directly which encodes spaces as +. This inconsistency could cause issues if via station names contain spaces and the API expects %20.

♻️ Suggested fix for consistent encoding

         if self.via_stations:
             encoded_via_stations = [
-                quote_plus(station.strip()) for station in self.via_stations
+                quote_plus(station.strip()).replace("+", "%20") for station in self.via_stations
             ]

---

570-593: Consider using dt_util.parse_datetime() for arrival time parsing.

The arrival time string parsing uses manual format attempts, while departure time parsing uses dt_util.parse_datetime() first. Using the same approach would be more consistent and handle additional formats automatically (including timezone-aware strings).

♻️ Suggested refactor for consistency

                             elif isinstance(scheduled_arrival, str):
-                                try:
-                                    arrival_time = dt_util.as_local(
-                                        datetime.strptime(
-                                            scheduled_arrival, "%Y-%m-%dT%H:%M:%S"
-                                        )
-                                    )
-                                except ValueError:
+                                parsed_arr = dt_util.parse_datetime(scheduled_arrival)
+                                if parsed_arr:
+                                    arrival_time = dt_util.as_local(parsed_arr)
+                                else:
+                                    # Fallback for HH:MM format
                                     try:
                                         arrival_time = dt_util.as_local(
                                             datetime.strptime(
-                                                scheduled_arrival, "%Y-%m-%dT%H:%M"
-                                            )
-                                        )
-                                    except ValueError:
-                                        arrival_time = dt_util.as_local(
-                                            datetime.strptime(
                                                 scheduled_arrival, "%H:%M"
                                             ).replace(
                                                 year=today.year,
                                                 month=today.month,
                                                 day=today.day,
                                             )
                                         )
+                                    except ValueError:
+                                        _LOGGER.warning(
+                                            "Unable to parse scheduledArrival: %s",
+                                            scheduled_arrival,
+                                        )

custom_components/db_infoscreen/__init__.py (1)

700-703: Consider more specific exception handling.

The broad except Exception provides resilience, but catching specific exceptions (e.g., aiohttp.ClientError, asyncio.TimeoutError, json.JSONDecodeError) would give more informative error messages.