Ensure that randomNumber holds a default nullable option (#291)

pimjansen · web-flow · commit e7f9a7ff28e2 · 2021-03-30T08:04:08.000+02:00
Co-authored-by: Pim Jansen &lt;pjansen@senet.nl&gt;
diff --git a/src/Faker/Generator.php b/src/Faker/Generator.php
@@ -470,7 +470,10 @@ public function randomFloat($nbMaxDecimals = null, $min = 0, $max = null): float
      */
     public function randomNumber($nbDigits = null, $strict = false): int
     {
-        return $this->ext(Extension\NumberExtension::class)->randomNumber((int) $nbDigits, (bool) $strict);
+        return $this->ext(Extension\NumberExtension::class)->randomNumber(
+            $nbDigits !== null ? (int) $nbDigits : null,
+            (bool) $strict
+        );
     }
 
     protected function callFormatWithMatches($matches)
diff --git a/test/Faker/Core/NumberTest.php b/test/Faker/Core/NumberTest.php
@@ -40,6 +40,11 @@ public function testRandomNumberThrowsExceptionWhenCalledWithATooHighNumberOfDig
         $this->faker->randomNumber(10);
     }
 
+    public function testRandomNumberHasValidNullableAutogenerate()
+    {
+        self::assertGreaterThan(0, $this->faker->randomNumber());
+    }
+
     public function testRandomNumberReturnsInteger()
     {
         self::assertIsInt($this->faker->randomNumber());

Original file line number	Diff line number	Diff line change
`@@ -470,7 +470,10 @@ public function randomFloat($nbMaxDecimals = null, $min = 0, $max = null): float`
`470`	`470`	`*/`
`471`	`471`	`public function randomNumber($nbDigits = null, $strict = false): int`
`472`	`472`	`{`
`473`		`- return $this->ext(Extension\NumberExtension::class)->randomNumber((int) $nbDigits, (bool) $strict);`
	`473`	`+ return $this->ext(Extension\NumberExtension::class)->randomNumber(`
	`474`	`+ $nbDigits !== null ? (int) $nbDigits : null,`
	`475`	`+ (bool) $strict`
	`476`	`+ );`
`474`	`477`	`}`
`475`	`478`
`476`	`479`	`protected function callFormatWithMatches($matches)`
Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,11 @@ public function testRandomNumberThrowsExceptionWhenCalledWithATooHighNumberOfDig`
`40`	`40`	`$this->faker->randomNumber(10);`
`41`	`41`	`}`
`42`	`42`
	`43`	`+ public function testRandomNumberHasValidNullableAutogenerate()`
	`44`	`+ {`
	`45`	`+ self::assertGreaterThan(0, $this->faker->randomNumber());`
	`46`	`+ }`
	`47`	`+`
`43`	`48`	`public function testRandomNumberReturnsInteger()`
`44`	`49`	`{`
`45`	`50`	`self::assertIsInt($this->faker->randomNumber());`