Fix: Return string (#726)

localheinz · web-flow · commit dd8df33d504e · 2023-09-04T22:18:20.000+02:00
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -15,11 +15,6 @@ parameters:
 			count: 1
 			path: src/Faker/Calculator/Luhn.php
 
-		-
-			message: "#^Method Faker\\\\Calculator\\\\Luhn\\:\\:computeCheckDigit\\(\\) should return string but returns int\\.$#"
-			count: 1
-			path: src/Faker/Calculator/Luhn.php
-
 		-
 			message: "#^Result of && is always false\\.$#"
 			count: 1
diff --git a/psalm.baseline.xml b/psalm.baseline.xml
@@ -1,13 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <files psalm-version="5.15.0@5c774aca4746caf3d239d9c8cadb9f882ca29352">
-  <file src="src/Faker/Calculator/Luhn.php">
-    <InvalidReturnStatement>
-      <code>0</code>
-    </InvalidReturnStatement>
-    <InvalidReturnType>
-      <code>string</code>
-    </InvalidReturnType>
-  </file>
   <file src="src/Faker/Generator.php">
     <InvalidReturnStatement>
       <code><![CDATA[$this->uniqueGenerator]]></code>
diff --git a/src/Faker/Calculator/Luhn.php b/src/Faker/Calculator/Luhn.php
@@ -44,7 +44,7 @@ public static function computeCheckDigit($partialNumber)
         $checkDigit = self::checksum($partialNumber . '0');
 
         if ($checkDigit === 0) {
-            return 0;
+            return '0';
         }
 
         return (string) (10 - $checkDigit);

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public static function computeCheckDigit($partialNumber)`
`44`	`44`	`$checkDigit = self::checksum($partialNumber . '0');`
`45`	`45`
`46`	`46`	`if ($checkDigit === 0) {`
`47`		`- return 0;`
	`47`	`+ return '0';`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`return (string) (10 - $checkDigit);`