Fix: Rename parameter (#731)

localheinz · web-flow · commit 81dcd6fffb08 · 2023-09-05T14:55:46.000+01:00
diff --git a/src/Faker/Container/ContainerBuilder.php b/src/Faker/Container/ContainerBuilder.php
@@ -18,20 +18,20 @@ final class ContainerBuilder
     private array $definitions = [];
 
     /**
-     * @param callable|object|string $value
+     * @param callable|object|string $definition
      *
      * @throws \InvalidArgumentException
      */
-    public function add(string $id, $value): self
+    public function add(string $id, $definition): self
     {
-        if (!is_string($value) && !is_callable($value) && !is_object($value)) {
+        if (!is_string($definition) && !is_callable($definition) && !is_object($definition)) {
             throw new \InvalidArgumentException(sprintf(
                 'First argument to "%s::add()" must be a string, callable or object.',
                 self::class,
             ));
         }
 
-        $this->definitions[$id] = $value;
+        $this->definitions[$id] = $definition;
 
         return $this;
     }

Original file line number	Diff line number	Diff line change
`@@ -18,20 +18,20 @@ final class ContainerBuilder`
`18`	`18`	`private array $definitions = [];`
`19`	`19`
`20`	`20`	`/**`
`21`		`- * @param callable\|object\|string $value`
	`21`	`+ * @param callable\|object\|string $definition`
`22`	`22`	`*`
`23`	`23`	`* @throws \InvalidArgumentException`
`24`	`24`	`*/`
`25`		`- public function add(string $id, $value): self`
	`25`	`+ public function add(string $id, $definition): self`
`26`	`26`	`{`
`27`		`- if (!is_string($value) && !is_callable($value) && !is_object($value)) {`
	`27`	`+ if (!is_string($definition) && !is_callable($definition) && !is_object($definition)) {`
`28`	`28`	`throw new \InvalidArgumentException(sprintf(`
`29`	`29`	`'First argument to "%s::add()" must be a string, callable or object.',`
`30`	`30`	`self::class,`
`31`	`31`	`));`
`32`	`32`	`}`
`33`	`33`
`34`		`- $this->definitions[$id] = $value;`
	`34`	`+ $this->definitions[$id] = $definition;`
`35`	`35`
`36`	`36`	`return $this;`
`37`	`37`	`}`