Fix: Remove unused method (#711)

localheinz · web-flow · commit 67208f90b019 · 2023-09-04T16:15:55.000+01:00
diff --git a/roave-bc-check.yaml b/roave-bc-check.yaml
@@ -19,3 +19,5 @@ parameters:
     - '#\[BC\] CHANGED: The number of required arguments for Faker\\Container\\ContainerBuilder\#add\(\) increased from 1 to 2#'
     - '#\[BC\] CHANGED: The parameter \$name of Faker\\Container\\ContainerBuilder\#add\(\) changed from string\|null to a non-contravariant string#'
     - '#\[BC\] CHANGED: The parameter \$value of Faker\\Container\\ContainerBuilder\#add\(\) changed from no type to a non-contravariant string#'
+    - '#\[BC\] REMOVED: Method Faker\\Container\\ContainerInterface\#getDefinitions\(\) was removed#'
+    - '#\[BC\] REMOVED: Method Faker\\Container\\Container\#getDefinitions\(\) was removed#'
diff --git a/src/Faker/Container/Container.php b/src/Faker/Container/Container.php
@@ -134,12 +134,4 @@ public function has($id): bool
 
         return array_key_exists($id, $this->definitions);
     }
-
-    /**
-     * Get the bindings between Extension interfaces and implementations.
-     */
-    public function getDefinitions(): array
-    {
-        return $this->definitions;
-    }
 }
diff --git a/src/Faker/Container/ContainerInterface.php b/src/Faker/Container/ContainerInterface.php
@@ -6,8 +6,4 @@
 
 interface ContainerInterface extends BaseContainerInterface
 {
-    /**
-     * Get the bindings between Extension interfaces and implementations.
-     */
-    public function getDefinitions(): array;
 }

Original file line number	Diff line number	Diff line change
`@@ -134,12 +134,4 @@ public function has($id): bool`
`134`	`134`
`135`	`135`	`return array_key_exists($id, $this->definitions);`
`136`	`136`	`}`
`137`		`-`
`138`		`- /**`
`139`		`- * Get the bindings between Extension interfaces and implementations.`
`140`		`- */`
`141`		`- public function getDefinitions(): array`
`142`		`- {`
`143`		`- return $this->definitions;`
`144`		`- }`
`145`	`137`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,4 @@`
`6`	`6`
`7`	`7`	`interface ContainerInterface extends BaseContainerInterface`
`8`	`8`	`{`
`9`		`- /**`
`10`		`- * Get the bindings between Extension interfaces and implementations.`
`11`		`- */`
`12`		`- public function getDefinitions(): array;`
`13`	`9`	`}`