Enhancement: Enable and configure list_syntax fixer (#220)

localheinz · web-flow · commit 1c73fa490d8f · 2020-12-22T11:04:39.000+01:00
* Enhancement: Enable and configure list_syntax fixer

* Fix: Run 'make cs'
diff --git a/.php_cs.dist b/.php_cs.dist
@@ -70,6 +70,9 @@ return $config
         'increment_style' => true,
         'is_null' => true,
         'lambda_not_used_import' => true,
+        'list_syntax' => [
+            'syntax' => 'short',
+        ],
         'lowercase_cast' => true,
         'lowercase_static_reference' => true,
         'magic_constant_casing' => true,
diff --git a/src/Faker/Provider/Payment.php b/src/Faker/Provider/Payment.php
@@ -250,7 +250,7 @@ public static function iban($countryCode = null, $prefix = '', $length = null)
                 $length = 0;
 
                 foreach ($format as $part) {
-                    list($class, $groupCount) = $part;
+                    [$class, $groupCount] = $part;
                     $length += $groupCount;
                 }
             }
@@ -263,7 +263,7 @@ public static function iban($countryCode = null, $prefix = '', $length = null)
         $expandedFormat = '';
 
         foreach ($format as $item) {
-            list($class, $length) = $item;
+            [$class, $length] = $item;
             $expandedFormat .= str_repeat($class, $length);
         }
 
diff --git a/test/Faker/Provider/ImageTest.php b/test/Faker/Provider/ImageTest.php
@@ -101,7 +101,7 @@ public function testDownloadWithDefaults()
         self::assertFileExists($file);
 
         if (function_exists('getimagesize')) {
-            list($width, $height, $type, $attr) = getimagesize($file);
+            [$width, $height, $type, $attr] = getimagesize($file);
             self::assertEquals(640, $width);
             self::assertEquals(480, $height);
             self::assertEquals(constant('IMAGETYPE_PNG'), $type);

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ public static function iban($countryCode = null, $prefix = '', $length = null)`
`250`	`250`	`$length = 0;`
`251`	`251`
`252`	`252`	`foreach ($format as $part) {`
`253`		`- list($class, $groupCount) = $part;`
	`253`	`+ [$class, $groupCount] = $part;`
`254`	`254`	`$length += $groupCount;`
`255`	`255`	`}`
`256`	`256`	`}`
`@@ -263,7 +263,7 @@ public static function iban($countryCode = null, $prefix = '', $length = null)`
`263`	`263`	`$expandedFormat = '';`
`264`	`264`
`265`	`265`	`foreach ($format as $item) {`
`266`		`- list($class, $length) = $item;`
	`266`	`+ [$class, $length] = $item;`
`267`	`267`	`$expandedFormat .= str_repeat($class, $length);`
`268`	`268`	`}`
`269`	`269`