Change default onDelete and OnUpdate log level to debug#800
Merged
sudermanjr merged 1 commit intoFairwindsOps:masterfrom Oct 16, 2025
Merged
Conversation
|
|
sudermanjr
previously requested changes
Oct 16, 2025
Contributor
Author
Alright sure, the linting was requested in the MR description but I could not run it properly due to some outdated package so I assumed a fix there would have helped. |
Member
Yeah, that should be removed from the instructions apparently. We control a lot of stuff outside this repo |
regressEdo
force-pushed
the
feature/change-handler-errors-to-debug
branch
from
32b1b94 to
38b12a0
Compare
sudermanjr
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #799
Checklist
Description
What's the goal of this PR?
The main goal is to reduce unnecessary error-level logging for expected but non-critical conditions in the event handlers. Currently, when
OnUpdateoronDeletereceive an unexpected object type or resource type, they log at the error level, which are not necessarily errors.By lowering the log level, we make logs less noisy and avoid false alarms in monitoring systems that watch for error-level logs.
What changes did you make?
Changed log statements for unknown object types in
OnUpdatefromklog.Errorftoklog.V(2).Infof.Changed log statements for unknown resource types in
onDeletefromklog.Errorftoklog.V(2).Infof.These log messages are now classified as verbose info logs instead of errors, reflecting their actual severity.