Harness unit test name #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue that happens when the folder holding the package being analyzed is not named as the package's name; in this scenario, the harness will not be evaluated. This happens because RcppDeepState uses the package name as the unit test name, and if a different name is supplied, Deepstate will not be unable to identify the test to execute.
I discovered this problem after running FabrizioSandri/RcppDeepState-action on binsegRcpp providing a custom test harness. I noticed that the supplied test harness had not been evaluated, with this message in the logs inside the artifact file:
INFO: Could not find matching test for workspace_generator; RcppDeepState was looking for theworkspace_generatortest that didn't exist.