Harness creation improvements - 2 #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
With the most recent commits, I modified the final harness structure by adding two macro definitions: one to prevent input definition duplication and the other to prevent cout duplication. I provide the automatically generated test harness for testSAN's #include <fstream>
#include <RInside.h>
#include <iostream>
#include <RcppDeepState.h>
#include <qs.h>
#include <DeepState.hpp>
RInside Rinstance;
int rcpp_read_out_of_bound(int rbound);
#define INPUTS \
IntegerVector rbound(1); \
rbound[0]= RcppDeepState_int();
#define PRINT_INPUTS \
std::cout << "input starts" << std::endl;\
std::cout << "rbound values: " << rbound << std::endl; \
std::cout << "input ends" << std::endl;
TEST(testSAN, generator){
INPUTS
PRINT_INPUTS
}
TEST(testSAN, runner){
INPUTS
PRINT_INPUTS
qs::c_qsave(rbound,"/home/fabri/test/testHarness/RcppDeepState/inst/testpkgs/testSAN/inst/testfiles/rcpp_read_out_of_bound/inputs/rbound.qs",
"high", "zstd", 1, 15, true, 1);
try{
rcpp_read_out_of_bound(rbound[0]);
}catch(Rcpp::exception& e){
std::cout<<"Exception Handled"<<std::endl;
}
} |
Collaborator
|
looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is designed to expand on pull request #5's work to improve the harness creation process.
I decided to revise the harness creation section and make some additional modifications in response to @tdhock's proposals, which are available at tdhock/binsegRcpp#13 (comment).