Add UndoManager support for graph operations#85
Merged
vade merged 2 commits intoFabric-Project:mainfrom Nov 17, 2025
Merged
Conversation
Addresses feedback from Fabric-Project#83 regarding zoom stutter caused by @Environment observation cascades. Marks Graph drag preview properties as @ObservationIgnored to prevent view recalculation during gestures. Calculates zoom anchor from current scroll position instead of gesture location to eliminate jumps between magnification gestures. Related: Fabric-Project#83, Fabric-Project#66
Implements undo/redo for node add/delete and port connect/disconnect. Fixes connections failing to update in render view during certain operations.
Contributor
|
Thanks! a brief review on mobile shows me some dispatch async code in the registration of the undo manager. Can you walk me through the rational for that? Anytime I see async code that also handles the main queue it’s a moment for me to pause and consider! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements undo/redo for node add/delete and port connect/disconnect.
Fixes connections failing to update in render view during certain operations.