Merged
Conversation
- displayName var - rename UI (only double-click for now)
- renamingNodeID in NodeCanvas, in order to toggle rename from context menu and block key shortcuts - compute isRenaming for each node - bigger hitbox
Contributor
|
Thanks so much! This looks good on first pass eyeball review! Gimme a bit to check it out in depth! Thank you again! |
Contributor
|
So one thing I would say, is we might want to limit double click to rename, as that 'enters' a subgraph node (nodes which have a more square body like Subgraph, Environment, Render to Image, Iterator) - if this usurps the double click for the node, it might be problematic! |
Contributor
Author
|
updated to a smaller hitbox for double click to rename |
Contributor
|
Thanks! I made a minor refactor to extract the logic to a self contained view, and remove some extraneous binding i didnt see was necessary! This is really nice! Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #123
Steps to test: