ArrayPtr: support for null pointer, converting from ref #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gebner
reviewed
Oct 29, 2025
lib/pulse/lib/Pulse.Lib.ArrayPtr.fst
Outdated
| type base_t ([@@@strictly_positive] a: Type0) = | ||
| | Null | ||
| | Ref of R.ref a | ||
| | Array of A.array a |
Contributor
There was a problem hiding this comment.
FYI, these days array a has both null pointers (A.null) and you can convert references to arrays (R.to_array).
Member
Author
There was a problem hiding this comment.
Thanks Gabriel! I reimplemented from_ref, etc. accordingly.
5 tasks
tahina-pro
force-pushed
the
_taramana_arrayptr_null
branch
from
2169669 to
6c276f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulse.Lib.ArrayPtr.ptr is the abstraction for flexible C pointer arithmetic used when extracting Pulse.Lib.Slice to C. This PR adds support for the null pointer in ArrayPtr (but not Slice), as well as the ability to convert from a Pulse.Lib.Reference.ref.
This is needed to define EverCBOR's safe C API with as few preconditions as possible.
(This only affects C extraction. In Rust, Slice enjoys primitive extraction and ArrayPtr cannot be used.)