bgp_bmp: do not send end of rib by default #19071
Conversation
|
ci:rerun |
|
Can you say why we shouldn't send EoR by default? Is there a use case, etc.? I don't think this will break any current deployments, but it might be good to say something about that as well (?). |
|
Currently, BMP sends an EoR for each supported policy type (Adj-RIB-In pre-policy, Adj-RIB-In post-policy, and Loc-RIB), regardless of the policy configuration. This may be confusing when a user only wants to monitor Adj-RIB-In pre-policy routes but still receives an EoR for Adj-RIB-In post-policy.
I do not think, this will help in scenarios where the user wants to receive EoR messages only for the configured policies, making monitoring more precise. |
|
Could you put this explanation into the commit message directly before we merge? |
Currently, BMP sends an EoR for each supported policy type (Adj-RIB-In pre-policy, Adj-RIB-In post-policy, and Loc-RIB), regardless of the policy configuration. This may be confusing when a user only wants to monitor Adj-RIB-In pre-policy routes but still receives an EoR for Adj-RIB-In post-policy. Do not send bmp EoR if the policy was not configured. Signed-off-by: Loïc Sang <[email protected]>
3 participants
Do not send bmp end of rib if the policy is not configured.