Skip to content

Conversation

@donaldsharp
Copy link
Member

See the individual commits, but ping was setup to fail no matter what if any packets are dropped, under heavy system test load, the kernel will drop packets.

The ping command was basically cut-n-pasted a bunch of times,
abstract the calling of ping to allow the test to have 1 version of
it.  This will allow us to change how ping operates in the test
in 1 spot in a future commit.

Signed-off-by: Donald Sharp <[email protected]>
Allow up to 90% failure rate on the ping.  If anything gets through
we know that nhrp is correctly adding the routes.  It's just under
very heavy load that this test can fail because the kernel will just
drop packets.

Signed-off-by: Donald Sharp <[email protected]>
@frrbot frrbot bot added the tests Topotests, make check, etc label Jun 18, 2025
@ton31337 ton31337 merged commit 2d66b22 into FRRouting:master Jun 19, 2025
16 checks passed
@Jafaral
Copy link
Member

Jafaral commented Jun 19, 2025

@Mergifyio backport dev/10.4

@mergify
Copy link

mergify bot commented Jun 19, 2025

backport dev/10.4

✅ Backports have been created

Details

ton31337 added a commit that referenced this pull request Jun 20, 2025
@donaldsharp donaldsharp deleted the nhrp_redundancy_ping branch July 30, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport master size/L tests Topotests, make check, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants