tests: Notice that the support_bundle is not properly setup #19045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the support_bundle is not properly setup, let's fail the test running so that the operator can fix this up. Signed-off-by: Donald Sharp <[email protected]>
This is now needed for proper test running. Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
support_bundle
branch
from
d6d28ec to
0b4e957
Compare
ton31337
approved these changes
Jun 19, 2025
| sudo install -m 775 -o frr -g frrvty -d /etc/frr | ||
| sudo install -m 640 -o frr -g frrvty tools/etc/frr/vtysh.conf /etc/frr/vtysh.conf | ||
| sudo install -m 640 -o frr -g frr tools/etc/frr/frr.conf /etc/frr/frr.conf | ||
| sudo install -m 640 -o frr -g frr tools/etc/frr/daemons.conf /etc/frr/daemons.conf |
Member
There was a problem hiding this comment.
Since you are here, can we drop this also?
Member
Author
There was a problem hiding this comment.
I really don't want to really go through the file and check the whole thing for correctness. It's a problem for a different day imo
Member
There was a problem hiding this comment.
I just saw you did a similar job already at 0b4e957, so I was thinking we can fix all of these, but fine.
| sudo install -m 775 -o frr -g frrvty -d /etc/frr | ||
| sudo install -m 640 -o frr -g frrvty tools/etc/frr/vtysh.conf /etc/frr/vtysh.conf | ||
| sudo install -m 640 -o frr -g frr tools/etc/frr/frr.conf /etc/frr/frr.conf | ||
| sudo install -m 640 -o frr -g frr tools/etc/frr/daemons.conf /etc/frr/daemons.conf |
| sudo install -m 775 -o frr -g frrvty -d /etc/frr | ||
| sudo install -m 640 -o frr -g frrvty tools/etc/frr/vtysh.conf /etc/frr/vtysh.conf | ||
| sudo install -m 640 -o frr -g frr tools/etc/frr/frr.conf /etc/frr/frr.conf | ||
| sudo install -m 640 -o frr -g frr tools/etc/frr/daemons.conf /etc/frr/daemons.conf |
| sudo install -m 775 -o frr -g frrvty -d /etc/frr | ||
| sudo install -m 640 -o frr -g frrvty tools/etc/frr/vtysh.conf /etc/frr/vtysh.conf | ||
| sudo install -m 640 -o frr -g frr tools/etc/frr/frr.conf /etc/frr/frr.conf | ||
| sudo install -m 640 -o frr -g frr tools/etc/frr/daemons.conf /etc/frr/daemons.conf |
| sudo install -m 775 -o frr -g frrvty -d /etc/frr | ||
| sudo install -m 640 -o frr -g frrvty tools/etc/frr/vtysh.conf /etc/frr/vtysh.conf | ||
| sudo install -m 640 -o frr -g frr tools/etc/frr/frr.conf /etc/frr/frr.conf | ||
| sudo install -m 640 -o frr -g frr tools/etc/frr/daemons.conf /etc/frr/daemons.conf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the support_bundle is not properly setup, let's fail the test running so that the operator can fix this up.