-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add frr-host yang module - fix bug with reserved IP range config #19019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
donaldsharp
merged 6 commits into
FRRouting:master
from
LabNConsulting:chopps/frr-host-yang-module
Jun 13, 2025
Merged
Add frr-host yang module - fix bug with reserved IP range config #19019
donaldsharp
merged 6 commits into
FRRouting:master
from
LabNConsulting:chopps/frr-host-yang-module
Jun 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Hopps <[email protected]>
3631c4b to
4eb0709
Compare
- Everyone loads frr-host module to process host config Signed-off-by: Christian Hopps <[email protected]>
cf9662f to
06c3386
Compare
Signed-off-by: Christian Hopps <[email protected]>
First use of flag is to decide whether to initialize the `host` CLI handlers in the daemon or not. Mgmtd daemons process `frr-host` config from mgmtd which handles the CLI, others still take it directly from VTY and so they need the DEFPY handlers. Signed-off-by: Christian Hopps <[email protected]>
Signed-off-by: Christian Hopps <[email protected]>
06c3386 to
b2f5241
Compare
ton31337
approved these changes
Jun 13, 2025
Member
ton31337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Need to add frr-host to the expected results when yang-library oper-state is checked. Signed-off-by: Christian Hopps <[email protected]>
Member
|
code works for me now too. |
Contributor
Author
|
@Mergifyio backport dev/10.4 |
✅ Backports have been createdDetails
|
ton31337
added a commit
that referenced
this pull request
Jun 15, 2025
Add frr-host yang module - fix bug with reserved IP range config (backport #19019)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new frr-host yang module with a single leaf value (so far)
allow-reserved-rangesto move this config from CLI to mgmtd. This avoids a race in zebra between IP config and this setting.