bgpd: Do not reuse the same adj->adv when flushing fifo (attributes too long) #18993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oo long) 2025/04/24 22:46:35 BGP: [N463T-4M950][EC 33554449] u4:s4 attributes too long, cannot send UPDATE BGP: Received signal 11 at 1745523995 (si_addr 0x30, PC 0x55f988339d30); aborting... BGP: /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0(zlog_backtrace_sigsafe+0x6f) [0x7f9ba3aca4cf] BGP: /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0(zlog_signal+0xf5) [0x7f9ba3aca6d5] BGP: /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0(+0x106481) [0x7f9ba3b06481] BGP: /lib/x86_64-linux-gnu/libc.so.6(+0x3c050) [0x7f9ba385b050] BGP: /usr/lib/frr/bgpd(bgp_advertise_clean_subgroup+0x20) [0x55f988339d30] BGP: /usr/lib/frr/bgpd(subgroup_update_packet+0x6db) [0x55f98833c8bb] BGP: /usr/lib/frr/bgpd(bgp_generate_updgrp_packets+0x439) [0x55f9882f3709] BGP: /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0(event_call+0x81) [0x7f9ba3b18d51] BGP: /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0(frr_run+0xc0) [0x7f9ba3ac1580] BGP: /usr/lib/frr/bgpd(main+0x3ce) [0x55f98828b88e] BGP: /lib/x86_64-linux-gnu/libc.so.6(+0x2724a) [0x7f9ba384624a] BGP: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x85) [0x7f9ba3846305] BGP: /usr/lib/frr/bgpd(_start+0x21) [0x55f98828d841] bgp_advertise_clean_subgroup() sets adj->adv = NULL (first iteration), then we pass the same adj and we have adj->adv NULL which is then dereferenced and crashing. Signed-off-by: Donatas Abraitis <[email protected]>
Member
|
@Mergifyio backport dev/10.4 |
✅ Backports have been createdDetails
|
2 tasks
ton31337
added a commit
that referenced
this pull request
Jun 11, 2025
bgpd: Do not reuse the same adj->adv when flushing fifo (attributes too long) (backport #18993)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.