babeld: Convert all code to use our code formatting rules #18630
Conversation
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Waiting on Alistair's discussion with Juliez ... |
|
I spoke to Juliusz last Friday. Here are the takeaways
|
donaldsharp
force-pushed
the
babel_conversion_to_clang_format
branch
from
026d278 to
6ab3888
Compare
mjstapp
left a comment
mjstapp
left a comment
There was a problem hiding this comment.
we should remove the exception for checkpatch now?
tools/checkpatch.sh:ignore="ldpd\|babeld"
The babeld code was originally kept in a non-standard format, at least to how FRR formats code, because the code came from outside the project and it was hoped that updates would be coming from the originators. That has not turned out to be true and we've been slowly getting bug-fixes for the code over the last year as it is being used. Let's just bite the bullet and convert over to our internal format for consistency. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
babel_conversion_to_clang_format
branch
from
cfce59b to
78480a3
Compare
Make babeld use checkpatch. Signed-off-by: Donald Sharp <[email protected]>
Babel is formatted correctly now so let's remove the exclusion Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
babel_conversion_to_clang_format
branch
from
78480a3 to
0d9d6a4
Compare
|
checkpatch is wrong for this last one. there are a series of if /else statements where some return and some don't. We should not remove the last else statement |
|
yes, we talked about this in slack, and it's not worth refactoring the clause that's triggering that warning (right now)
|
|
Hello Team, |
6 participants
The babeld code was originally kept in a non-standard format, at least to how FRR formats code, because the code came from outside the project and it was hoped that updates would be coming from the originators. That has not turned out to be true and we've been slowly getting bug-fixes for the code over the last year
as it is being used. Let's just bite the bullet
and convert over to our internal format for consistency.