Repository navigation
fix(desktop): links that open a new tab (Google Sign in) navigate the Browser again - #544
Merged
Merged
Conversation
…he Browser again on_new_window called navigate from inside WebKit's createWebView delegate. Tauri runs a main-thread navigate synchronously, so the load started while WebKit was still handling the click and was dropped: target=_blank links did nothing. Google Voice's "Sign in" (target=_blank → accounts.google.com) never moved, for the person or the agent. The navigate is now posted from another thread, so it runs after the delegate returns. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Jtb7WudoN4jCe3AMkAeWQj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on_new_window called navigate from inside WebKit's createWebView delegate. Tauri runs a
main-thread navigate synchronously, so the load started while WebKit was still handling the
click and was dropped: target=_blank links did nothing. Google Voice's "Sign in"
(target=_blank → accounts.google.com) never moved, for the person or the agent.
The navigate is now posted from another thread, so it runs after the delegate returns.
Gate:
cargo test --lib browser11/11. Needs a person to click: test build spike-15 on hive-002.🤖 Generated with Claude Code
https://claude.ai/code/session_01Jtb7WudoN4jCe3AMkAeWQj