Repository navigation
Commit 813f17d
fix(data-sources): s3 was ingestable all along, and
#182734, measured with the CLI's own survey:
16 source(s) · 1 bulk-importable
8 connected source(s) are hidden from discovery (incl. google-drive)
TWO DIFFERENT DEFECTS.
1. UNDER-REPORTING, not a missing feature. fl-api's
BloqIngestionController::startFolderIngestion validates
`in:dropbox,google_drive,s3`, and FileIngestionService switches on all three
with each implemented. This CLI advertised two. So `sync` could always take
s3 and nothing said so.
I went looking to widen this list much further — the catalog offers 49 source
types — and the server says no. Three is the real ceiling, and adding a
fourth here would turn a truthful "read-only" into a promise that fails at
run time. Widening it is a SERVER change. The constant now says that, and a
test pins it to exactly the server's rule in both directions: adding a type
the server rejects fails, and dropping one we ship fails.
2. `list` IS A DISCOVERY SURFACE AND IT READ ONE SIDE. `survey` already joins
the availability list against real connections and reports the delta — that
join is the whole reason survey exists. `list` did not do it, so 8 connected,
executable sources were absent from the surface that answers "what can I
use", including google-drive with three working accounts: simultaneously the
only bulk-importable source we have and invisible in the list.
`list` now runs the same join and shows what it finds, labelled, with the
command that works. --json carries them too, flagged hidden_but_connected,
because omitting a real source is the bug rather than the tidy answer. A
failed join degrades to the old behaviour instead of dropping sources.
Does not touch the LINK half — entity resolution and typed relations are bloq
anomalyco#629, and this is only about gather.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_019wF7NrsCHAhXRn3ZddtQv5list was reading one side of a join1 parent 0a754f2 commit 813f17d
2 files changed
Lines changed: 136 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
304 | 305 | | |
305 | 306 | | |
306 | 307 | | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
159 | | - | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
160 | 175 | | |
161 | 176 | | |
162 | 177 | | |
| |||
314 | 329 | | |
315 | 330 | | |
316 | 331 | | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
317 | 355 | | |
318 | | - | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
319 | 369 | | |
320 | 370 | | |
321 | 371 | | |
322 | | - | |
| 372 | + | |
323 | 373 | | |
324 | 374 | | |
325 | 375 | | |
| |||
352 | 402 | | |
353 | 403 | | |
354 | 404 | | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
355 | 416 | | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
356 | 423 | | |
357 | 424 | | |
358 | 425 | | |
| |||
0 commit comments