Repository navigation
fix(ag-ui): address #8163 review on pause checkpoint ownership - #2
Merged
FOWEPJF255 merged 1 commit intoSep 11, 2026
Conversation
- Workflow captures run baseline / restored id inside run(); resolve uses them so callers need not thread baseline_checkpoint_id. - Exclude restored checkpoint from pause candidates after resume. - Drop issue reference in docstring; emit RUN_FINISHED via existing _build_run_finished_event after attaching pause id. - Move core pause-resolve coverage into test_workflow.py (no new test file).
Merged
5 tasks done
Owner
|
Thanks for addressing the pause-checkpoint ownership notes on microsoft#8163. I will review this fork PR next and push the ownership fixes upstream so workflow owns the run boundary as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Follow-up for microsoft#8163 review threads from @eavanvalkenburg and @moonbox3.
Description & Review Guide
_run_corecaptures_run_baseline_checkpoint_idand_restored_checkpoint_id;resolve_pause_checkpoint_iduses them by default._build_run_finished_event(no_build_run_finished_with_checkpointed_interrupts); move core tests intotest_workflow.pyand delete the dedicated test file.baseline_checkpoint_id/ resumeknown_checkpoint_idthrough RUN_FINISHED.Happy to adjust naming if you prefer a different helper split.