Mwm recipes#24
Closed
marcmengel wants to merge 2 commits intoFNALssi:fnal-developfrom
marcmengel:mwm_recipes
Closed
Mwm recipes#24marcmengel wants to merge 2 commits intoFNALssi:fnal-developfrom marcmengel:mwm_recipes
marcmengel wants to merge 2 commits intoFNALssi:fnal-developfrom
marcmengel:mwm_recipes
Conversation
Member
|
Is there any reason not to submit all these new recipes as (separate) upstream PRs? I'm fine with putting them in our fork first but I'd hate to be running just from our fork and then have some enterprising individual submit different versions of some of these upstream and have it turn into a merging nightmare. For the same reason (you're going to hate me for this) I'd prefer these be individual PRs with the title, "New package: XXX" to make the merging more straightforward when they are accepted upstream. |
greenc-FNAL
requested changes
Oct 22, 2019
Member
There was a problem hiding this comment.
Several of these recipes still have FIXME messages and boilerplate that should be removed. Also see non-review comment re splitting into individual PRs.
Author
|
Sigh.. You're probably right. Yes the only reason not to submit them
separately upstream is tedium :-).
…On Tue, Oct 22, 2019 at 10:03 AM Chris Green ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Several of these recipes still have FIXME messages and boilerplate that
should be removed. Also see non-review comment re splitting into individual
PRs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24?email_source=notifications&email_token=AAB6GV5XZBPU5XCHRIWH6VDQP4I4NA5CNFSM4JDEEFAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIZDWTQ#pullrequestreview-305281870>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB6GV4OCR3BQIN4WSNKBZTQP4I4NANCNFSM4JDEEFAA>
.
|
greenc-FNAL
force-pushed
the
fnal-develop
branch
from
ddc2e5d to
20de47a
Compare
greenc-FNAL
force-pushed
the
fnal-develop
branch
from
36abe63 to
d4afd4f
Compare
Member
|
@marcmengel Is this PR still meaningful? |
Author
|
Nah, just close it out. I'll maybe contribute some of them upstream when I get a round to-it. |
marcmengel
pushed a commit
that referenced
this pull request
Apr 21, 2023
1. support version 3.1.3, which now depends on sundials@6 2. support version 3.1.2:, which broke the two patch files and therefore the two patch files have been replaced by more flexible filter_file() commands inside a patch() function. 3. rename the variant for python extension from using the package name "+pyuqtk" to the more standard "+python" 4. add maintainers @omsai and the upstream developer @bjdebus who offered to help with the spack packaging. 5. swig should only be a build-time dependency. swig is only necessary until @:3.1.0 6. confirmed python dependencies are correct by inspecting imports, subset python dependencies type to build, run, and confirmed all 31 build-time tests pass including the 9 python tests: ```console $ spack env create uqtk-dev $ spack add [email protected] $ spack install --test root && cat $(spack location -i uqtk)/.spack/install-time-test-log.txt ==> Testing package uqtk-3.1.3-nok6fut ==> [2023-04-19-14:56:25.005361] Running build-time tests ==> [2023-04-19-14:56:25.005536] RUN-TESTS: build-time tests [check] ==> [2023-04-19-14:56:25.009543] '/home/omsai/src/spack/opt/spack/linux-pureos10-skylake/gcc-10.2.1/gmake-4.4.1-b6g4apmfvxz3bn4eabh37dehcrg65fj7/bin/make' '-j4' '-n' 'test' ==> [2023-04-19-14:56:25.014903] '/home/omsai/src/spack/opt/spack/linux-pureos10-skylake/gcc-10.2.1/gmake-4.4.1-b6g4apmfvxz3bn4eabh37dehcrg65fj7/bin/make' '-j4' 'test' Running tests... /home/omsai/src/spack/opt/spack/linux-pureos10-skylake/gcc-10.2.1/cmake-3.26.3-zjmsfz23j5l4ytniz26uzvxonlu5qebr/bin/ctest --force-new-ctest-process Test project /tmp/omsai/spack-stage/spack-stage-uqtk-3.1.3-nok6fut47h42cnaau7wkoohgqy5f2qqa/spack-build-nok6fut Start 1: ArrayReadAndWrite Start 2: ArrayDelColumn Start 3: Array1DMiscTest Start 4: Array2DMiscTest 1/31 Test #1: ArrayReadAndWrite ................ Passed 0.01 sec Start 5: ArraySortTest 2/31 Test #2: ArrayDelColumn ................... Passed 0.01 sec Start 6: MultiIndexTest 3/31 Test #3: Array1DMiscTest .................. Passed 0.01 sec Start 7: CorrTest 4/31 Test #4: Array2DMiscTest .................. Passed 0.01 sec Start 8: QuadLUTest 5/31 Test #5: ArraySortTest .................... Passed 0.02 sec Start 9: MCMC2dTest 6/31 Test #6: MultiIndexTest ................... Passed 0.01 sec Start 10: MCMCRandomTest 7/31 Test #8: QuadLUTest ....................... Passed 0.02 sec Start 11: MCMCNestedTest 8/31 Test #10: MCMCRandomTest ................... Passed 0.02 sec Start 12: Deriv1dTest 9/31 Test #12: Deriv1dTest ...................... Passed 0.01 sec Start 13: SecondDeriv1dTest 10/31 Test #13: SecondDeriv1dTest ................ Passed 0.01 sec Start 14: GradHessianTest 11/31 Test #11: MCMCNestedTest ................... Passed 0.03 sec Start 15: GradientPCETest 12/31 Test #14: GradHessianTest .................. Passed 0.01 sec Start 16: PCE1dTest 13/31 Test #15: GradientPCETest .................. Passed 0.01 sec Start 17: PCEImplTest 14/31 Test #16: PCE1dTest ........................ Passed 0.01 sec Start 18: PCELogTest 15/31 Test #18: PCELogTest ....................... Passed 0.01 sec Start 19: Hessian2dTest 16/31 Test #19: Hessian2dTest .................... Passed 0.01 sec Start 20: BCS1dTest 17/31 Test #20: BCS1dTest ........................ Passed 0.01 sec Start 21: BCS2dTest 18/31 Test #21: BCS2dTest ........................ Passed 0.01 sec Start 22: LowRankRegrTest 19/31 Test #22: LowRankRegrTest .................. Passed 0.01 sec Start 23: PyModTest 20/31 Test #17: PCEImplTest ...................... Passed 0.07 sec Start 24: PyArrayTest 21/31 Test #23: PyModTest ........................ Passed 0.08 sec Start 25: PyArrayTest2 22/31 Test #25: PyArrayTest2 ..................... Passed 0.30 sec Start 26: PyQuadTest 23/31 Test #24: PyArrayTest ...................... Passed 1.44 sec Start 27: PyBCSTest1D 24/31 Test #26: PyQuadTest ....................... Passed 1.68 sec Start 28: PyBCSTest2D 25/31 Test #27: PyBCSTest1D ...................... Passed 1.66 sec Start 29: PyBADPTest 26/31 Test #7: CorrTest ......................... Passed 3.43 sec Start 30: PyRegressionTest 27/31 Test #28: PyBCSTest2D ...................... Passed 1.50 sec Start 31: PyGalerkinTest 28/31 Test #9: MCMC2dTest ....................... Passed 3.90 sec 29/31 Test #29: PyBADPTest ....................... Passed 1.66 sec 30/31 Test #30: PyRegressionTest ................. Passed 1.72 sec 31/31 Test #31: PyGalerkinTest ................... Passed 1.63 sec 100% tests passed, 0 tests failed out of 31 Total Test time (real) = 5.35 sec ==> [2023-04-19-14:56:30.382797] '/home/omsai/src/spack/opt/spack/linux-pureos10-skylake/gcc-10.2.1/gmake-4.4.1-b6g4apmfvxz3bn4eabh37dehcrg65fj7/bin/make' '-j4' '-n' 'check' ==> [2023-04-19-14:56:30.385983] Target 'check' not found in Makefile ```
greenc-FNAL
pushed a commit
that referenced
this pull request
Apr 28, 2023
A missing dependency, showing up as: ```console #24 1113.1 3 errors found in build log: #24 1113.1 20 -- Check for working CXX compiler: /opt/spack/lib/spack/env/gcc/g++ #24 1113.1 - skipped #24 1113.1 21 -- Detecting CXX compile features #24 1113.1 22 -- Detecting CXX compile features - done #24 1113.1 23 -- Found CURL: /opt/software/linux-debian-x86_64_v3/gcc-12.2.0/curl- #24 1113.1 7.85.0-ca5zznsdkp2hwbnikha6sgqzcpuw74sc/lib/libcurl.so (found versio #24 1113.1 n "7.85.0") #24 1113.1 24 -- Found UUID : /opt/software/linux-debian-x86_64_v3/gcc-12.2.0/util #24 1113.1 -linux-uuid-2.38.1-45xrjgjjauvev5qarwji7xgmlnhqlzkh/lib/libuuid.so #24 1113.1 25 -- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) #24 1113.1 >> 26 CMake Error at /opt/software/linux-debian-x86_64_v3/gcc-12.2.0/cmake #24 1113.1 -3.24.3-6doi3daa6ihw6mk4zbk5oiiuiaahsny7/share/cmake-3.24/Modules/Fi #24 1113.1 ndPkgConfig.cmake:663 (message): #24 1113.1 27 pkg-config tool not found #24 1113.1 28 Call Stack (most recent call first): #24 1113.1 29 /opt/software/linux-debian-x86_64_v3/gcc-12.2.0/cmake-3.24.3-6doi3 #24 1113.1 daa6ihw6mk4zbk5oiiuiaahsny7/share/cmake-3.24/Modules/FindPkgConfig.c #24 1113.1 make:829 (_pkg_check_modules_internal) #24 1113.1 30 CMakeLists.txt:39 (pkg_check_modules) #24 1113.1 31 #24 1113.1 32 ``` Ref: https://github.com/scitokens/scitokens-cpp/blob/v1.0.0/CMakeLists.txt#L32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assorted recipes for using spack to setup the POMS service from Fermilab, including uwsgi, cherrypy, etc.